[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #22131: feat(ssh_tunnel): Delete command & exceptions

[GitBox <gi...@apache.org>]

Antonio-RiveroMartnez commented on code in PR #22131:
URL: https://github.com/apache/superset/pull/22131#discussion_r1024257241


##########
superset/databases/commands/delete_ssh_tunnel.py:
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import logging
+from typing import Optional
+
+from flask_appbuilder.models.sqla import Model
+
+from superset.commands.base import BaseCommand
+from superset.dao.exceptions import DAODeleteFailedError
+from superset.databases.commands.exceptions import (
+    SSHTunnelDeleteFailedError,
+    SSHTunnelNotFoundError,
+)
+from superset.databases.models import SSHTunnel
+from superset.databases.ssh_tunnel_dao import SSHTunnelDAO
+
+logger = logging.getLogger(__name__)
+
+
+class DeleteSSHTunnelCommand(BaseCommand):
+    def __init__(self, model_id: int):
+        self._model_id = model_id
+        self._model: Optional[SSHTunnel] = None
+
+    def run(self) -> Model:

Review Comment:
   Oh yeah! Let me add those for this and the update one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org