[jira] [Commented] (SLING-10920) Converter doesn't reset the aclManager after first pass and rejects too much after resets

["Karl Pauls (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443760#comment-17443760 ] 

Karl Pauls commented on SLING-10920:
------------------------------------

[~angela] - I merged this already but I still would like to have your review. I think it is doing the right thing but it maybe it needs more improvement (which we might need a new issue for). Basically, the idea is to keep a global list of the service users encountered to allow for acls in a feature that didn't bring the service users. That has the downside that it will miss service users created by repoinit (especially if they are coming from the seed). That would have been the case before as well so I don't think it is making things worse but I guess I might be missing something.

> Converter doesn't reset the aclManager after first pass and rejects too much after resets
> -----------------------------------------------------------------------------------------
>
>                 Key: SLING-10920
>                 URL: https://issues.apache.org/jira/browse/SLING-10920
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>    Affects Versions: Content-Package to Feature Model Converter 1.1.10
>            Reporter: Karl Pauls
>            Assignee: Karl Pauls
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> The converter doesn't reset the acl manager after the first pass. That makes it so that the service users are collected and put into the all feature. Furthermore, if it resets, it is loosing the acls that have matching service users but that come too later in the contenpackage.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)