You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "kberezin-nshl (via GitHub)" <gi...@apache.org> on 2023/08/22 14:41:59 UTC
[GitHub] [beam] kberezin-nshl opened a new pull request, #28093: SpannerIO: retry if concurrent transaction is aborted by emulator
kberezin-nshl opened a new pull request, #28093:
URL: https://github.com/apache/beam/pull/28093
Fixes https://github.com/apache/beam/issues/28092
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28093: SpannerIO: retry if concurrent transaction is aborted by emulator
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28093:
URL: https://github.com/apache/beam/pull/28093#issuecomment-1697646814
Sorry, this slipped through the cracks a bit
@johnjcasey could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kberezin-nshl commented on pull request #28093: SpannerIO: retry if concurrent transaction is aborted by emulator
Posted by "kberezin-nshl (via GitHub)" <gi...@apache.org>.
kberezin-nshl commented on PR #28093:
URL: https://github.com/apache/beam/pull/28093#issuecomment-1689446949
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #28093: SpannerIO: retry if concurrent transaction is aborted by emulator
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #28093:
URL: https://github.com/apache/beam/pull/28093#issuecomment-1696430691
@damccorm could you check or suggest a reviewer ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kberezin-nshl commented on pull request #28093: SpannerIO: retry if concurrent transaction is aborted by emulator
Posted by "kberezin-nshl (via GitHub)" <gi...@apache.org>.
kberezin-nshl commented on PR #28093:
URL: https://github.com/apache/beam/pull/28093#issuecomment-1688343217
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #28093: SpannerIO: retry if concurrent transaction is aborted by emulator
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #28093:
URL: https://github.com/apache/beam/pull/28093#issuecomment-1697865248
This LGTM, just adding another retry scenario.
I'm rerunning the tests that failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28093: SpannerIO: retry if concurrent transaction is aborted by emulator
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28093:
URL: https://github.com/apache/beam/pull/28093#issuecomment-1688346405
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey merged pull request #28093: SpannerIO: retry if concurrent transaction is aborted by emulator
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey merged PR #28093:
URL: https://github.com/apache/beam/pull/28093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org