[GitHub] [incubator-doris] morningman commented on a change in pull request #7167: [optimize]Add Doris restart script, optimize doris start and stop commands

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7167:
URL: https://github.com/apache/incubator-doris/pull/7167#discussion_r754179070



##########
File path: bin/doris_be.sh
##########
@@ -0,0 +1,61 @@
+#!/bin/bash

Review comment:
       License header.

##########
File path: bin/doris_be.sh
##########
@@ -0,0 +1,61 @@
+#!/bin/bash
+
+export DORIS_HOME=`cd "$curdir"; pwd`
+export LOG_DIR=${DORIS_HOME}/log

Review comment:
       the `LOG_DIR` should read from config file.

##########
File path: bin/doris_be.sh
##########
@@ -0,0 +1,61 @@
+#!/bin/bash
+
+export DORIS_HOME=`cd "$curdir"; pwd`
+export LOG_DIR=${DORIS_HOME}/log
+export PID_DIR=`cd "$curdir"; pwd`
+function start() {
+    echo "Starting Apache Doris Frontend"
+    sh $DORIS_HOME/bin/start_be.sh --daemon
+    if [ -f "$DORIS_HOME/bin/be.pid" ]; then
+       echo "Apache Doris Backend start fail!"
+    else
+      sleep 1s
+      pid=`cat $DORIS_HOME/bin/be.pid`
+      echo "Doris Be pid : ${pid}"
+      echo `sed -n '$p' $DORIS_HOME/log/be.out`
+      echo "Apache Doris Backend start success!"
+    fi
+}
+
+function stop() {
+    echo "stop Apache Doris Frontend"
+    sh $DORIS_HOME/bin/stop_be.sh
+    if [ -f "$DORIS_HOME/bin/be.pid" ]; then
+       echo "Apache Doris Backend stop fail!"
+    else
+       echo "Apache Doris Backend stop success!"
+    fi
+}
+
+function restart() {
+    echo "Restart Apache Doris Backend"
+    echo "****************************"
+    echo "Ready to stop Doris Backend"
+    stop

Review comment:
       The process may be in defunct status for a long time, so start right after stop may failed to start BE process.

##########
File path: bin/doris_be.sh
##########
@@ -0,0 +1,61 @@
+#!/bin/bash
+
+export DORIS_HOME=`cd "$curdir"; pwd`
+export LOG_DIR=${DORIS_HOME}/log
+export PID_DIR=`cd "$curdir"; pwd`
+function start() {
+    echo "Starting Apache Doris Frontend"
+    sh $DORIS_HOME/bin/start_be.sh --daemon
+    if [ -f "$DORIS_HOME/bin/be.pid" ]; then
+       echo "Apache Doris Backend start fail!"
+    else
+      sleep 1s
+      pid=`cat $DORIS_HOME/bin/be.pid`
+      echo "Doris Be pid : ${pid}"
+      echo `sed -n '$p' $DORIS_HOME/log/be.out`

Review comment:
       the log dir may be elsewhere




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org