[jira] [Closed] (FLINK-7995) Created curator/zk module in flink-shaded

["Till Rohrmann (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Rohrmann closed FLINK-7995.
--------------------------------
    Resolution: Duplicate

> Created curator/zk module in flink-shaded
> -----------------------------------------
>
>                 Key: FLINK-7995
>                 URL: https://issues.apache.org/jira/browse/FLINK-7995
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Priority: Major
>
> I propose creating a dedicated curator/zookeeper module in flink-shaded.
> Zookeeper & curator are dependencies that are used in multiple modules (kafka 0.8, runtime, mesos), which, since these dependencies are shaded, cause more headaches than ultimately necessary.
> For example, the shading of curator is done in flink-runtime, when really it should happen in flink-shaded curator. This is done as otherwise the shading pattern in flink-runtime would have to be kept in sync with the one in flink-shaded-curator.
> This is also exactly what the kafka connector does, whereas flink-mesos goes through utility methods in flink-runtime that wrap the actual zk/curator accesses.
> What's worse is that you have to _know_ that you must account for the shading. Any module depending on flink-runtime is free to import unshaded curator, neither the IDE nor maven will complain, and tests generally don't catch shading issues.
> A separate flink-shaded module that bundles zookeeper and curator would alleviate these issues.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)