You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 14:02:46 UTC
[GitHub] [airflow] nlecoy opened a new pull request #15919: Add `s3_keys` to `template_fields` and optional on_error kwargs for `S3ToSnowflakeOperator`
nlecoy opened a new pull request #15919:
URL: https://github.com/apache/airflow/pull/15919
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR adds `s3_keys` to `template_fiels` so it can be correctly used with Jinja. Also, adds an optional kwargs `on_error` that specifies the action Snowflake has to perform when an error is encountered while loading data from a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nlecoy commented on pull request #15919: Add an optional `on_error` kwargs for `S3ToSnowflakeOperator`
Posted by GitBox <gi...@apache.org>.
nlecoy commented on pull request #15919:
URL: https://github.com/apache/airflow/pull/15919#issuecomment-843521216
Hi @potiuk, sure ! I just updated this PR adding some testing and removing the template_fields. I also opened a new PR to add this template_field to S3ToSnowflake, available here https://github.com/apache/airflow/pull/15926
Have a nice day
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #15919: Add an optional `on_error` kwargs for `S3ToSnowflakeOperator`
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #15919:
URL: https://github.com/apache/airflow/pull/15919#issuecomment-859746549
@nlecoy can you fix the failing test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15919: Add `s3_keys` to `template_fields` and optional on_error kwargs for `S3ToSnowflakeOperator`
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15919:
URL: https://github.com/apache/airflow/pull/15919#issuecomment-843290659
Also Ideally - this PR shoudl be split into two as those two changes are independent, and it is much better if they are separated (for history/changelog/cherry-picks/reverts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15919: Add `s3_keys` to `template_fields` and optional on_error kwargs for `S3ToSnowflakeOperator`
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15919:
URL: https://github.com/apache/airflow/pull/15919#issuecomment-843289900
Woudl you mind adding a test ? I think the operator is pretty well covered by unit tests and adding "on_error" tests should be easy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #15919: Add an optional `on_error` kwargs for `S3ToSnowflakeOperator`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #15919:
URL: https://github.com/apache/airflow/pull/15919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15919: Add an optional `on_error` kwargs for `S3ToSnowflakeOperator`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15919:
URL: https://github.com/apache/airflow/pull/15919#issuecomment-843596153
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15919: Add an optional `on_error` kwargs for `S3ToSnowflakeOperator`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15919:
URL: https://github.com/apache/airflow/pull/15919#issuecomment-887109387
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org