[GitHub] [helix] desaikomal commented on a change in pull request #1984: add new error message for customized partition check host connection error

[GitBox <gi...@apache.org>]

desaikomal commented on a change in pull request #1984:
URL: https://github.com/apache/helix/pull/1984#discussion_r828551899



##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -257,11 +258,16 @@ public static boolean hasErrorPartitions(HelixDataAccessor dataAccessor, String
               continue;
             }
 
-            // We are checking sibling partition healthy status. So if partition health does not
-            // exist or it is not healthy. We should mark this partition is unhealthy.
+            // If we failed to get partition assignment for one sibling instance, we add the
+            // nstance name in return error for debugability

Review comment:
       typo: debuggability




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org