You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/03/23 12:57:42 UTC
Review Request 45210: Fix PMD "BooleanInstantiation" issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45210/
-----------------------------------------------------------
Review request for ranger.
Repository: ranger
Description
-------
Fix PMD "BooleanInstantiation" issues
Diffs
-----
dev-support/ranger-pmd-ruleset.xml 5dd3851
security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java 3f92d8d
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 3c0eb95
security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java 405f7c4
Diff: https://reviews.apache.org/r/45210/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 45210: Fix PMD "BooleanInstantiation" issues
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45210/#review125376
-----------------------------------------------------------
Ship it!
Ship It!
- Alok Lal
On March 24, 2016, 4:39 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45210/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 4:39 a.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix PMD "BooleanInstantiation" issues
>
>
> Diffs
> -----
>
> dev-support/ranger-pmd-ruleset.xml 4db1881
> security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java c911c1f
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 3c0eb95
> security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java 405f7c4
>
> Diff: https://reviews.apache.org/r/45210/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 45210: Fix PMD "BooleanInstantiation" issues
Posted by Don Bosco Durai <bo...@apache.org>.
Can someone from the Ranger dev team help Colm commit this patch?
Thanks
Bosco
From: Don Bosco Durai <no...@reviews.apache.org> on behalf of Don Bosco Durai <bo...@apache.org>
Reply-To: Don Bosco Durai <bo...@apache.org>
Date: Thursday, March 24, 2016 at 11:07 AM
To: ranger <de...@ranger.incubator.apache.org>, Colm O hEigeartaigh <co...@apache.org>, Don Bosco Durai <bo...@apache.org>
Subject: Re: Review Request 45210: Fix PMD "BooleanInstantiation" issues
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45210/
Ship it!
Ship It!
- Don Bosco Durai
On March 24th, 2016, 11:39 a.m. UTC, Colm O hEigeartaigh wrote:
Review request for ranger.
By Colm O hEigeartaigh.
Updated March 24, 2016, 11:39 a.m. Repository: ranger
Description
Fix PMD "BooleanInstantiation" issues
Diffs
dev-support/ranger-pmd-ruleset.xml (4db1881)
security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java (c911c1f)
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java (3c0eb95)
security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java (405f7c4)
View Diff
Re: Review Request 45210: Fix PMD "BooleanInstantiation" issues
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45210/#review125305
-----------------------------------------------------------
Ship it!
Ship It!
- Don Bosco Durai
On March 24, 2016, 11:39 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45210/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 11:39 a.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix PMD "BooleanInstantiation" issues
>
>
> Diffs
> -----
>
> dev-support/ranger-pmd-ruleset.xml 4db1881
> security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java c911c1f
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 3c0eb95
> security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java 405f7c4
>
> Diff: https://reviews.apache.org/r/45210/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 45210: Fix PMD "BooleanInstantiation" issues
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45210/
-----------------------------------------------------------
(Updated March 24, 2016, 11:39 a.m.)
Review request for ranger.
Repository: ranger
Description
-------
Fix PMD "BooleanInstantiation" issues
Diffs (updated)
-----
dev-support/ranger-pmd-ruleset.xml 4db1881
security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java c911c1f
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 3c0eb95
security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java 405f7c4
Diff: https://reviews.apache.org/r/45210/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 45210: Fix PMD "BooleanInstantiation" issues
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45210/#review125037
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java (line 574)
<https://reviews.apache.org/r/45210/#comment187792>
I now this is existing code, but as a part of this change, should we explicitly set this to "false"? It is just that making a boolean value of "null" seems wrong.
- Don Bosco Durai
On March 23, 2016, 11:57 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45210/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 11:57 a.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix PMD "BooleanInstantiation" issues
>
>
> Diffs
> -----
>
> dev-support/ranger-pmd-ruleset.xml 5dd3851
> security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java 3f92d8d
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 3c0eb95
> security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java 405f7c4
>
> Diff: https://reviews.apache.org/r/45210/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>