[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4493: Recover VM not able to attach the data disks which were attached before destroy

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on pull request #4493:
URL: https://github.com/apache/cloudstack/pull/4493#issuecomment-783095522


   If we agree upon treating the volumes as first class citizens during the VM destroy and making them independent of VM after it is destroyed then we need to fix this for other hypervisor types also.
   
   In this PR we are trying to bring back the old behaviour of keeping the disks attached to the destroyed VM.
   
   In my opinion, this PR is still required because without this PR the behaviour(what we need now) of detaching disks from VM upon destroy is applicable only for VMware. So I would say, lets revert back to old behaviour and fix the volume detachment process as we need for all hypervisor types, test it completely, document the new behaviour as a new improvement ticket.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org