You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/02 02:49:46 UTC

[GitHub] [pulsar] wolfstudy opened a new pull request #14527: Update go client version to 0.8.0 for Go Function

wolfstudy opened a new pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527


   Signed-off-by: xiaolongran <xi...@tencent.com>
   
   
   
   ### Motivation
   
   Update go client version to 0.8.0 for Go Function
   
   ### Modifications
   
   Update `go.mod` file
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #14527: Update go client version to 0.8.1 for Go Function

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#issuecomment-1081405942


   ![image](https://user-images.githubusercontent.com/20965307/160536946-6b88dab3-97f9-4ca5-a0f9-2cec8d4d4d83.png)
   The action CI error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #14527: Update go client version to 0.8.1 for Go Function

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#issuecomment-1080232702


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on a change in pull request #14527: Update go client version to 0.8.0 for Go Function

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#discussion_r834014449



##########
File path: pulsar-function-go/go.mod
##########
@@ -3,15 +3,16 @@ module github.com/apache/pulsar/pulsar-function-go
 go 1.13
 
 require (
-	github.com/apache/pulsar-client-go v0.7.0
-	github.com/golang/protobuf v1.4.3
-	github.com/prometheus/client_golang v1.7.1
+	github.com/apache/pulsar-client-go v0.8.0
+	github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect
+	github.com/golang/protobuf v1.5.2
+	github.com/prometheus/client_golang v1.11.0

Review comment:
       Good ideas, will upgrade go sdk version to 081




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on a change in pull request #14527: Update go client version to 0.8.1 for Go Function

Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#discussion_r840528016



##########
File path: pulsar-function-go/go.mod
##########
@@ -3,15 +3,16 @@ module github.com/apache/pulsar/pulsar-function-go
 go 1.13
 
 require (
-	github.com/apache/pulsar-client-go v0.7.0
-	github.com/golang/protobuf v1.4.3
-	github.com/prometheus/client_golang v1.7.1
+	github.com/apache/pulsar-client-go v0.8.1
+	github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect

Review comment:
       https://github.com/apache/pulsar-client-go/blob/3e1b39dd6f88aa0a12b949b1d1e064bde6355e22/oauth2/go.mod#L7 seems to be used in pulsar-client-go/oauth2




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on a change in pull request #14527: Update go client version to 0.8.1 for Go Function

Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#discussion_r840522622



##########
File path: pulsar-function-go/go.mod
##########
@@ -3,15 +3,16 @@ module github.com/apache/pulsar/pulsar-function-go
 go 1.13
 
 require (
-	github.com/apache/pulsar-client-go v0.7.0
-	github.com/golang/protobuf v1.4.3
-	github.com/prometheus/client_golang v1.7.1
+	github.com/apache/pulsar-client-go v0.8.1
+	github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect

Review comment:
       There's an existing advisory about this library: https://github.com/advisories/GHSA-w73w-5m7g-f7qc . Can we migrate to https://github.com/golang-jwt/jwt ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #14527: Update go client version to 0.8.1 for Go Function

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#issuecomment-1081671075


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14527: Update go client version to 0.8.0 for Go Function

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#issuecomment-1056091546


   @wolfstudy:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on a change in pull request #14527: Update go client version to 0.8.1 for Go Function

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#discussion_r840552073



##########
File path: pulsar-function-go/go.mod
##########
@@ -3,15 +3,16 @@ module github.com/apache/pulsar/pulsar-function-go
 go 1.13
 
 require (
-	github.com/apache/pulsar-client-go v0.7.0
-	github.com/golang/protobuf v1.4.3
-	github.com/prometheus/client_golang v1.7.1
+	github.com/apache/pulsar-client-go v0.8.1
+	github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect

Review comment:
       The Go SDK does not directly reference this lib. This is indirectly referenced by other packages, and we cannot modify it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14527: Update go client version to 0.8.0 for Go Function

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #14527:
URL: https://github.com/apache/pulsar/pull/14527#discussion_r817448864



##########
File path: pulsar-function-go/go.mod
##########
@@ -3,15 +3,16 @@ module github.com/apache/pulsar/pulsar-function-go
 go 1.13
 
 require (
-	github.com/apache/pulsar-client-go v0.7.0
-	github.com/golang/protobuf v1.4.3
-	github.com/prometheus/client_golang v1.7.1
+	github.com/apache/pulsar-client-go v0.8.0
+	github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect
+	github.com/golang/protobuf v1.5.2
+	github.com/prometheus/client_golang v1.11.0

Review comment:
       1.11.0 is flagged with a critical CVE, could you upgrade it to 1.11.1 ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org