You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alastair Maw (JIRA)" <ji...@apache.org> on 2006/10/16 21:40:35 UTC
[jira] Created: (WICKET-6) Configuration of app mode isn't
customisable
Configuration of app mode isn't customisable
--------------------------------------------
Key: WICKET-6
URL: http://issues.apache.org/jira/browse/WICKET-6
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.2.2, 1.2.3, 1.3, 2.0
Reporter: Alastair Maw
Priority: Minor
Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-6:
------------------------------
Fix Version/s: 1.3
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: https://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 1.3, 2.0
> Reporter: Alastair Maw
> Assigned To: Alastair Maw
> Priority: Minor
> Fix For: 1.3
>
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489976 ]
Jean-Baptiste Quenot commented on WICKET-6:
-------------------------------------------
Can't you just override init() and call configure() according to your Spring configuration? That's what we do. There's always the need to override init() anyway, as DEVELOPMENT or DEPLOYMENT is not sufficient in most cases, often other settings need to be tweaked.
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: https://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 1.3, 2.0
> Reporter: Alastair Maw
> Assigned To: Alastair Maw
> Priority: Minor
> Fix For: 1.3
>
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-6?page=comments#action_12442709 ]
Igor Vaynberg commented on WICKET-6:
------------------------------------
but that was to read the configuration type after the app has been configured rather then actually control the configuration correct?
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: http://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 2.0, 1.3
> Reporter: Alastair Maw
> Priority: Minor
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-6?page=all ]
Igor Vaynberg reassigned WICKET-6:
----------------------------------
Assignee: Igor Vaynberg
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: http://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 2.0, 1.3
> Reporter: Alastair Maw
> Assigned To: Igor Vaynberg
> Priority: Minor
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-6?page=all ]
Igor Vaynberg reassigned WICKET-6:
----------------------------------
Assignee: Alastair Maw (was: Igor Vaynberg)
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: http://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 2.0, 1.3
> Reporter: Alastair Maw
> Assigned To: Alastair Maw
> Priority: Minor
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-6?page=comments#action_12442698 ]
Eelco Hillenius commented on WICKET-6:
--------------------------------------
No objections, but I just added getConfigurationType to application last week. That one could be made overridable. If you prefer getConfigurationMode to type, that'd be fine with me; the change hasn't been part of a release yet, and thus wouldn't break compat.
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: http://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 1.3, 2.0
> Reporter: Alastair Maw
> Priority: Minor
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-6?page=comments#action_12442737 ]
Alastair Maw commented on WICKET-6:
-----------------------------------
Given I suspect we're only ever going to have two types, I'd actually vote for having an overridable isDevelopmentModeActive(), but whatever - I'm not that fussed about nomenclature. And yes, important distinction - this is to configure it in the first place, not just to read the setting after the event (which I agree is also often required). Of course the two could end up being the same function.
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: http://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 1.3, 2.0
> Reporter: Alastair Maw
> Priority: Minor
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-6?page=comments#action_12442749 ]
Igor Vaynberg commented on WICKET-6:
------------------------------------
the original vision behind the string is that you can create your own, but i suspect you are right. that discussion belongs on the list though.
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: http://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 2.0, 1.3
> Reporter: Alastair Maw
> Priority: Minor
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-6.
-------------------------------
Resolution: Fixed
Following discussion on wicket-dev@, have made getConfigurationType() abstract in Application and provided a default implementation in WebApplication so this can be overridden and used in a pull-type way.
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: https://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 2.0 branch (discontinued), trunk
> Reporter: Alastair Maw
> Assignee: Alastair Maw
> Priority: Minor
> Fix For: 1.3.0-beta2
>
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-6) Configuration of app mode isn't
customisable
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-6:
------------------------------
Fix Version/s: (was: 1.3.0)
1.3.0-beta2
> Configuration of app mode isn't customisable
> --------------------------------------------
>
> Key: WICKET-6
> URL: https://issues.apache.org/jira/browse/WICKET-6
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.2, 1.2.3, 1.3.0, 2.0
> Reporter: Alastair Maw
> Assigned To: Alastair Maw
> Priority: Minor
> Fix For: 1.3.0-beta2
>
>
> Everything else in wicket is programatically configurable apart from DEPLOYMENT or DEVELOPMENT app modes. I can't set System properties due to security constraints, and I don't want to have to set things up in web.xml because it's tedious and I already have which deployment ID I'm using configured somewhere else, using Spring.
> I talked to ivaynberg about this on ##wicket, and we reckon Application should have an abstract getConfigurationMode():String function, which is overridden in WebApplication and PortletApplication appropriately, to replicate current functionality. The default implementations should /not/ be final, so you can override them to pull the config from wherever you like.
> If anyone has any objections to changing things to work like this, please shout now, otherwise I will supply a patch for 1.x and trunk shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.