You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Kinga Marton via Review Board <no...@reviews.apache.org> on 2018/07/01 10:02:57 UTC

Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67766/
-----------------------------------------------------------

(Updated July 1, 2018, 10:02 a.m.)


Review request for oozie and András Piros.


Repository: oozie-git


Description
-------

Currently Findbugs complains about some warnings related to the reliance on the default encoding in the oozie-client module:
They should be fixed to get the code more reliable.


Diffs (updated)
-----

  client/src/main/java/org/apache/oozie/cli/CLIParser.java bbdb80356 
  client/src/main/java/org/apache/oozie/cli/OozieCLI.java bc234e318 
  client/src/main/java/org/apache/oozie/client/AuthOozieClient.java 98f421f32 
  client/src/main/java/org/apache/oozie/client/OozieClient.java 2cc169230 
  client/src/main/java/org/apache/oozie/client/XOozieClient.java ba60f8e75 


Diff: https://reviews.apache.org/r/67766/diff/3/

Changes: https://reviews.apache.org/r/67766/diff/2-3/


Testing
-------


Thanks,

Kinga Marton


Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67766/#review205634
-----------------------------------------------------------


Ship it!




Ship It!

- András Piros


On July 2, 2018, 8:06 a.m., Kinga Marton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67766/
> -----------------------------------------------------------
> 
> (Updated July 2, 2018, 8:06 a.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Currently Findbugs complains about some warnings related to the reliance on the default encoding in the oozie-client module:
> They should be fixed to get the code more reliable.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/oozie/cli/CLIParser.java bbdb80356 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java bc234e318 
>   client/src/main/java/org/apache/oozie/client/AuthOozieClient.java 98f421f32 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 2cc169230 
>   client/src/main/java/org/apache/oozie/client/XOozieClient.java ba60f8e75 
> 
> 
> Diff: https://reviews.apache.org/r/67766/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>


Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67766/
-----------------------------------------------------------

(Updated July 2, 2018, 8:06 a.m.)


Review request for oozie and András Piros.


Repository: oozie-git


Description
-------

Currently Findbugs complains about some warnings related to the reliance on the default encoding in the oozie-client module:
They should be fixed to get the code more reliable.


Diffs (updated)
-----

  client/src/main/java/org/apache/oozie/cli/CLIParser.java bbdb80356 
  client/src/main/java/org/apache/oozie/cli/OozieCLI.java bc234e318 
  client/src/main/java/org/apache/oozie/client/AuthOozieClient.java 98f421f32 
  client/src/main/java/org/apache/oozie/client/OozieClient.java 2cc169230 
  client/src/main/java/org/apache/oozie/client/XOozieClient.java ba60f8e75 


Diff: https://reviews.apache.org/r/67766/diff/5/

Changes: https://reviews.apache.org/r/67766/diff/4-5/


Testing
-------


Thanks,

Kinga Marton


Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67766/
-----------------------------------------------------------

(Updated July 1, 2018, 10:19 a.m.)


Review request for oozie and András Piros.


Changes
-------

findbug fix


Repository: oozie-git


Description
-------

Currently Findbugs complains about some warnings related to the reliance on the default encoding in the oozie-client module:
They should be fixed to get the code more reliable.


Diffs (updated)
-----

  client/src/main/java/org/apache/oozie/cli/CLIParser.java bbdb80356 
  client/src/main/java/org/apache/oozie/cli/OozieCLI.java bc234e318 
  client/src/main/java/org/apache/oozie/client/AuthOozieClient.java 98f421f32 
  client/src/main/java/org/apache/oozie/client/OozieClient.java 2cc169230 
  client/src/main/java/org/apache/oozie/client/XOozieClient.java ba60f8e75 


Diff: https://reviews.apache.org/r/67766/diff/4/

Changes: https://reviews.apache.org/r/67766/diff/3-4/


Testing
-------


Thanks,

Kinga Marton