You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fory.apache.org by "esafak (via GitHub)" <gi...@apache.org> on 2025/09/01 16:46:03 UTC
[PR] fix(ci): Exit with subprocess return code in run_ci.py [fory]
esafak opened a new pull request, #2560:
URL: https://github.com/apache/fory/pull/2560
## Why?
CI was not reflecting failures in shell script fallbacks (we are migrating to python)
## What does this PR do?
* Use sys.exit() to propagate the return code from subprocess.call().
* This ensures that the CI pipeline correctly reflects the success or failure of the executed scripts.
## Related issues
Fixes #2555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] fix(ci): Exit with subprocess return code in run_ci.py [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #2560:
URL: https://github.com/apache/fory/pull/2560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] fix(ci): Exit with subprocess return code in run_ci.py [fory]
Posted by "esafak (via GitHub)" <gi...@apache.org>.
esafak commented on PR #2560:
URL: https://github.com/apache/fory/pull/2560#issuecomment-3243614509
You might want to revert c7a1a99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] fix(ci): Exit with subprocess return code in run_ci.py [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #2560:
URL: https://github.com/apache/fory/pull/2560#issuecomment-3243919522
> Can you fix the remaining graal error?
I'm working on it, it's a little compilcated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] fix(ci): Exit with subprocess return code in run_ci.py [fory]
Posted by "esafak (via GitHub)" <gi...@apache.org>.
esafak commented on PR #2560:
URL: https://github.com/apache/fory/pull/2560#issuecomment-3243868899
Can you fix the remaining graal error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org