[jira] Commented: (HARMONY-3228) [drlvm][jit][opt] Dacapo.xalan hangs up with default server+inliner options

["Mikhail Fursov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476862 ] 

Mikhail Fursov commented on HARMONY-3228:
-----------------------------------------

My review:
Patch is OK and should work as expected

Minor issues:
a) Why do you need .h file declarations?
b) findClosestMonExit actually eliminates closest monexits
c) instead of StlSet<Node*>& monexits we can use bool[] array with node ids used as indexes.
d) I think that dominator tree check is useless here. 



> [drlvm][jit][opt] Dacapo.xalan hangs up with default server+inliner options
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-3228
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3228
>             Project: Harmony
>          Issue Type: Bug
>          Components: App-Oriented Bug Reports, DRLVM
>            Reporter: Vladimir Strigun
>         Attachments: reg_test.patch, so2.patch
>
>
> With the next inliner option included to default server.emconf Dacapo.xalan hangs up after several iteration. Inliner options:
> -XDjit.arg.optimizer.inline.growth_factor=210
> -XDjit.arg.optimizer.inline.min_stop=240
> -XDjit.arg.optimizer.inline.inline_small_method_max_size=75
> -XDjit.arg.optimizer.inline.medium_method_max_size=1400
> -XDjit.arg.optimizer.inline.large_method_min_size=1150
> -XDjit.arg.optimizer.inline.leaf_bonus=2160
> -XDjit.arg.optimizer.inline.synch_bonus=60
> -XDjit.arg.optimizer.inline.min_benefit_threshold=70
> -XDjit.arg.optimizer.inline.inline_small_method_bonus=1000
> -XDjit.arg.optimizer.inline.medium_method_bonus=300
> -XDjit.arg.optimizer.inline.loop_bonus=200
> -XDjit.arg.optimizer.inline.recursion_penalty=600
> -XDjit.arg.optimizer.inline.exact_single_parameter_bonus=70
> -XDjit.arg.optimizer.inline.exact_all_parameter_bonus=140
> Command line and output:
> java -showversion -Xbootclasspath/p: xalan.jar -Xmx1024M -Xms1024M -Dgc.lp=true -Xem:server_inline -cp . Harness -n 10 xalan
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r509175, (Feb 19 2007), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> WARNING: max heap size is too large, reduced to 900 Mb
> WARNING: min heap size reduced to 900 Mb
> ===== DaCapo xalan starting warmup =====
> Normal completion.
> ===== DaCapo xalan completed warmup in 29397 msec =====
> ===== DaCapo xalan starting warmup =====
> Normal completion.
> ===== DaCapo xalan completed warmup in 6484 msec =====
> ===== DaCapo xalan starting warmup =====
> Normal completion.
> ===== DaCapo xalan completed warmup in 5939 msec =====
> ===== DaCapo xalan starting warmup =====
> Normal completion.
> ===== DaCapo xalan completed warmup in 5783 msec =====
> ===== DaCapo xalan starting warmup =====
> Normal completion.
> ===== DaCapo xalan completed warmup in 5565 msec =====
> ===== DaCapo xalan starting warmup =====
> Normal completion.
> ===== DaCapo xalan completed warmup in 5471 msec =====
> ===== DaCapo xalan starting warmup =====
> Normal completion.
> ===== DaCapo xalan completed warmup in 5658 msec =====
> ===== DaCapo xalan starting warmup =====
> Normal completion.
> ===== DaCapo xalan completed warmup in 5440 msec =====
> ===== DaCapo xalan starting warmup =====
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.