You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2015/09/15 00:36:59 UTC
Change in hyracks[master]: This change fixes the sporadic connection refused errors aft...
Till Westmann has posted comments on this change.
Change subject: This change fixes the sporadic connection refused errors after managix starts up an Asterix instance. This can mostly be seen during asterix-installer tests. The fix basically lets managix wait and listens through zookeeper for a signal from the cluster c
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/365
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0975308e1dc2650d8c2e50d58ff2c696b22eaaa4
Gerrit-PatchSet: 3
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Re: Change in hyracks[master]: This change fixes the sporadic
connection refused errors aft...
Posted by Till Westmann <ti...@apache.org>.
I agree that - unless we decide to do another Hyracks release before the
AsterixDB release, we should not make changes to AsterixDB that rely on
modifications of Hyracks after 0.2.16-incubating.
Cheers,
Till
On 27 Sep 2015, at 23:21, Chris Hillery wrote:
> I believe we can merge this one now that Hyracks has been released,
> but it
> won't do any good without the corresponding Asterix change which is
> what
> really fixes the problems. And I'm pretty sure we don't want to merge
> anything to Asterix master before it gets released.
>
> I'm going to send a followup email about that...
>
> Ceej
> On Sep 27, 2015 8:50 PM, "Murtadha Hubail" <hu...@gmail.com>
> wrote:
>
>> Can we get this change merged?
>>
>> I wasted 2 days trying to debug a test case failure that happens on
>> the
>> server and doesn’t happen on my machine.
>>
>> Turns out because I added a couple of logging messages for datasets
>> memory
>> allocation and deallocation, the NC was taking more time to register
>> with
>> the CC and the query is submitted before the cluster is active. I
>> couldn’t
>> figure out the reason right away because the returned error message
>> is not
>> formatted in JSON, which triggered another bug that raises a JSON
>> format
>> exception instead of the actual error message.
>>
>> Regard,
>> Murtadha
>>
>>> On Sep 14, 2015, at 3:36 PM, Till Westmann (Code Review) <
>> do-not-reply@asterixdb.incubator.apache.org> wrote:
>>>
>>> Till Westmann has posted comments on this change.
>>>
>>> Change subject: This change fixes the sporadic connection refused
>>> errors
>> after managix starts up an Asterix instance. This can mostly be seen
>> during
>> asterix-installer tests. The fix basically lets managix wait and
>> listens
>> through zookeeper for a signal from the cluster c
>>> ......................................................................
>>>
>>>
>>> Patch Set 3: Code-Review+2
>>>
>>> --
>>> To view, visit https://asterix-gerrit.ics.uci.edu/365
>>> To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
>>>
>>> Gerrit-MessageType: comment
>>> Gerrit-Change-Id: I0975308e1dc2650d8c2e50d58ff2c696b22eaaa4
>>> Gerrit-PatchSet: 3
>>> Gerrit-Project: hyracks
>>> Gerrit-Branch: master
>>> Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
>>> Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
>>> Gerrit-Reviewer: Ian Maxon <im...@apache.org>
>>> Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
>>> Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
>>> Gerrit-Reviewer: Till Westmann <ti...@apache.org>
>>> Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
>>> Gerrit-HasComments: No
>>
>>
Re: Change in hyracks[master]: This change fixes the sporadic
connection refused errors aft...
Posted by Chris Hillery <ce...@lambda.nu>.
I believe we can merge this one now that Hyracks has been released, but it
won't do any good without the corresponding Asterix change which is what
really fixes the problems. And I'm pretty sure we don't want to merge
anything to Asterix master before it gets released.
I'm going to send a followup email about that...
Ceej
On Sep 27, 2015 8:50 PM, "Murtadha Hubail" <hu...@gmail.com> wrote:
> Can we get this change merged?
>
> I wasted 2 days trying to debug a test case failure that happens on the
> server and doesn’t happen on my machine.
>
> Turns out because I added a couple of logging messages for datasets memory
> allocation and deallocation, the NC was taking more time to register with
> the CC and the query is submitted before the cluster is active. I couldn’t
> figure out the reason right away because the returned error message is not
> formatted in JSON, which triggered another bug that raises a JSON format
> exception instead of the actual error message.
>
> Regard,
> Murtadha
>
> > On Sep 14, 2015, at 3:36 PM, Till Westmann (Code Review) <
> do-not-reply@asterixdb.incubator.apache.org> wrote:
> >
> > Till Westmann has posted comments on this change.
> >
> > Change subject: This change fixes the sporadic connection refused errors
> after managix starts up an Asterix instance. This can mostly be seen during
> asterix-installer tests. The fix basically lets managix wait and listens
> through zookeeper for a signal from the cluster c
> > ......................................................................
> >
> >
> > Patch Set 3: Code-Review+2
> >
> > --
> > To view, visit https://asterix-gerrit.ics.uci.edu/365
> > To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
> >
> > Gerrit-MessageType: comment
> > Gerrit-Change-Id: I0975308e1dc2650d8c2e50d58ff2c696b22eaaa4
> > Gerrit-PatchSet: 3
> > Gerrit-Project: hyracks
> > Gerrit-Branch: master
> > Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
> > Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
> > Gerrit-Reviewer: Ian Maxon <im...@apache.org>
> > Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
> > Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
> > Gerrit-Reviewer: Till Westmann <ti...@apache.org>
> > Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
> > Gerrit-HasComments: No
>
>
Re: Change in hyracks[master]: This change fixes the sporadic
connection refused errors aft...
Posted by abdullah alamoudi <ba...@gmail.com>.
I would like to do so but been waiting for the release to be done. This is
a two part change (Hyracks and Asterix).
Should I go ahead or wait?
Amoudi, Abdullah.
On Mon, Sep 28, 2015 at 6:50 AM, Murtadha Hubail <hu...@gmail.com>
wrote:
> Can we get this change merged?
>
> I wasted 2 days trying to debug a test case failure that happens on the
> server and doesn’t happen on my machine.
>
> Turns out because I added a couple of logging messages for datasets memory
> allocation and deallocation, the NC was taking more time to register with
> the CC and the query is submitted before the cluster is active. I couldn’t
> figure out the reason right away because the returned error message is not
> formatted in JSON, which triggered another bug that raises a JSON format
> exception instead of the actual error message.
>
> Regard,
> Murtadha
>
> > On Sep 14, 2015, at 3:36 PM, Till Westmann (Code Review) <
> do-not-reply@asterixdb.incubator.apache.org> wrote:
> >
> > Till Westmann has posted comments on this change.
> >
> > Change subject: This change fixes the sporadic connection refused errors
> after managix starts up an Asterix instance. This can mostly be seen during
> asterix-installer tests. The fix basically lets managix wait and listens
> through zookeeper for a signal from the cluster c
> > ......................................................................
> >
> >
> > Patch Set 3: Code-Review+2
> >
> > --
> > To view, visit https://asterix-gerrit.ics.uci.edu/365
> > To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
> >
> > Gerrit-MessageType: comment
> > Gerrit-Change-Id: I0975308e1dc2650d8c2e50d58ff2c696b22eaaa4
> > Gerrit-PatchSet: 3
> > Gerrit-Project: hyracks
> > Gerrit-Branch: master
> > Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
> > Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
> > Gerrit-Reviewer: Ian Maxon <im...@apache.org>
> > Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
> > Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
> > Gerrit-Reviewer: Till Westmann <ti...@apache.org>
> > Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
> > Gerrit-HasComments: No
>
>
Re: Change in hyracks[master]: This change fixes the sporadic connection refused errors aft...
Posted by Murtadha Hubail <hu...@gmail.com>.
Can we get this change merged?
I wasted 2 days trying to debug a test case failure that happens on the server and doesn’t happen on my machine.
Turns out because I added a couple of logging messages for datasets memory allocation and deallocation, the NC was taking more time to register with the CC and the query is submitted before the cluster is active. I couldn’t figure out the reason right away because the returned error message is not formatted in JSON, which triggered another bug that raises a JSON format exception instead of the actual error message.
Regard,
Murtadha
> On Sep 14, 2015, at 3:36 PM, Till Westmann (Code Review) <do...@asterixdb.incubator.apache.org> wrote:
>
> Till Westmann has posted comments on this change.
>
> Change subject: This change fixes the sporadic connection refused errors after managix starts up an Asterix instance. This can mostly be seen during asterix-installer tests. The fix basically lets managix wait and listens through zookeeper for a signal from the cluster c
> ......................................................................
>
>
> Patch Set 3: Code-Review+2
>
> --
> To view, visit https://asterix-gerrit.ics.uci.edu/365
> To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I0975308e1dc2650d8c2e50d58ff2c696b22eaaa4
> Gerrit-PatchSet: 3
> Gerrit-Project: hyracks
> Gerrit-Branch: master
> Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
> Gerrit-Reviewer: Chris Hillery <ce...@lambda.nu>
> Gerrit-Reviewer: Ian Maxon <im...@apache.org>
> Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
> Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
> Gerrit-Reviewer: Till Westmann <ti...@apache.org>
> Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
> Gerrit-HasComments: No