You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/15 13:58:05 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1963:
fix checkOtherParams invoke logic
codecov-io commented on issue #1963: fix checkOtherParams invoke logic
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1963#issuecomment-586592737
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963?src=pr&el=h1) Report
> Merging [#1963](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/c6f252451bd68fe54f4da95eeeb0c76fbf3c6c0b?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `20%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1963 +/- ##
============================================
- Coverage 30.41% 30.37% -0.05%
Complexity 1367 1367
============================================
Files 294 294
Lines 14964 14968 +4
Branches 1800 1801 +1
============================================
- Hits 4552 4547 -5
- Misses 9959 9968 +9
Partials 453 453
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `74.39% <0%> (-0.57%)` | `84 <0> (ø)` | |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100% <100%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | `2% <0%> (ø)` | |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.1% <0%> (-2.04%)` | `14% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963?src=pr&el=footer). Last update [c6f2524...931cf54](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1963?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services