You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/24 00:00:11 UTC
[jira] [Commented] (CB-13485) Not tested against Node 8
[ https://issues.apache.org/jira/browse/CB-13485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216096#comment-16216096 ]
ASF GitHub Bot commented on CB-13485:
-------------------------------------
GitHub user akdor1154 opened a pull request:
https://github.com/apache/cordova-lib/pull/601
CB-13485: Test with Node8
### What does this PR do?
Enables testing on Node 8 with Travis, and fixes the failing tests (no behaviour changes seem necessary).
### What testing has been done on this change?
`npm test`
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akdor1154/cordova-lib node8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/601.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #601
----
commit 8e38e274cdd140717766fc43a4b28934f4106e64
Author: Jarrad Whitaker <jw...@officeworks.com.au>
Date: 2017-10-23T23:38:55Z
Test Node 8 with Travis
commit 0a704ab17d420273d95c6efeeee3cc7b7774d6f3
Author: Jarrad Whitaker <jw...@officeworks.com.au>
Date: 2017-10-23T23:51:26Z
fix error test on Node 8
----
> Not tested against Node 8
> -------------------------
>
> Key: CB-13485
> URL: https://issues.apache.org/jira/browse/CB-13485
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Reporter: Jarrad Whitaker
> Priority: Minor
> Labels: test
>
> Tests aren't run against Node 8 in travis.
> This is a slight problem as a couple of them fail for trivial reasons (error string matching).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org