You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/01/14 17:23:55 UTC
Review Request 29886: Views: Throwing exception to ambari-server.log
on bad view validation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29886/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-9123
https://issues.apache.org/jira/browse/AMBARI-9123
Repository: ambari
Description
-------
When a validator fails for a view instance, we are printing a stack trace to ambari-server log as WARN. We shouldn't be printing a stack trace to the log.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 08d55f9
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 54a96ea
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 147beaa
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 2cbaed2
ambari-server/src/main/java/org/apache/ambari/server/view/validation/ValidationException.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java 3aa17d1
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java f25bd4d
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 1897a0c
Diff: https://reviews.apache.org/r/29886/diff/
Testing
-------
Manual testing. New unit tests added. All tests pass.
Thanks,
Tom Beerbower
Re: Review Request 29886: Views: Throwing exception to
ambari-server.log on bad view validation
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29886/#review68059
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 14, 2015, 11:23 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29886/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 11:23 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-9123
> https://issues.apache.org/jira/browse/AMBARI-9123
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a validator fails for a view instance, we are printing a stack trace to ambari-server log as WARN. We shouldn't be printing a stack trace to the log.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 08d55f9
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 54a96ea
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 147beaa
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 2cbaed2
> ambari-server/src/main/java/org/apache/ambari/server/view/validation/ValidationException.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java 3aa17d1
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java f25bd4d
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 1897a0c
>
> Diff: https://reviews.apache.org/r/29886/diff/
>
>
> Testing
> -------
>
> Manual testing. New unit tests added. All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>