You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/06/15 14:30:19 UTC
Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/
-----------------------------------------------------------
Review request for lens and Rajat Khandelwal.
Bugs: LENS-605
https://issues.apache.org/jira/browse/LENS-605
Repository: lens
Description
-------
Fixes Candidate pruning wrt sourcecolumns required for joinchains
- Fixes when multiple tables not reachable for a candidate. Added regression tests
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c5d8d91
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
Diff: https://reviews.apache.org/r/35459/diff/
Testing
-------
All cube tests pass.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On June 18, 2015, 6:52 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, line 388
> > <https://reviews.apache.org/r/35459/diff/1/?file=984670#file984670line388>
> >
> > I think we don't need to pass `(String[])null`, varargs takes care of that automatically.
It was giving warning in my IDE.
> On June 18, 2015, 6:52 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java, line 98
> > <https://reviews.apache.org/r/35459/diff/1/?file=984672#file984672line98>
> >
> > The new function can be used?
No. New function call is only for joinchains.
> On June 18, 2015, 6:52 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java, line 169
> > <https://reviews.apache.org/r/35459/diff/1/?file=984674#file984674line169>
> >
> > Is this change related?
Yes. Now we are adding the queried, instead of source columns.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/#review88344
-----------------------------------------------------------
On June 16, 2015, 7:15 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35459/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 7:15 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-605
> https://issues.apache.org/jira/browse/LENS-605
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes Candidate pruning wrt sourcecolumns required for joinchains
>
> - Fixes when multiple tables not reachable for a candidate. Added regression tests
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c5d8d91
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
>
> Diff: https://reviews.apache.org/r/35459/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [6.972s]
> [INFO] Lens .............................................. SUCCESS [10.815s]
> [INFO] Lens API .......................................... SUCCESS [42.589s]
> [INFO] Lens API for server and extensions ................ SUCCESS [29.129s]
> [INFO] Lens Cube ......................................... SUCCESS [5:44.521s]
> [INFO] Lens DB storage ................................... SUCCESS [39.222s]
> [INFO] Lens Query Library ................................ SUCCESS [24.951s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:46.073s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [52.714s]
> [INFO] Lens Server ....................................... SUCCESS [36:12.315s]
> [INFO] Lens client ....................................... SUCCESS [2:07.156s]
> [INFO] Lens CLI .......................................... SUCCESS [13:16.990s]
> [INFO] Lens Examples ..................................... SUCCESS [22.787s]
> [INFO] Lens Distribution ................................. SUCCESS [38.863s]
> [INFO] Lens ML Lib ....................................... SUCCESS [5:37.658s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [28.590s]
> [INFO] Lens Regression ................................... SUCCESS [25.328s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:13:07.899s
> [INFO] Finished at: Tue Jun 16 12:43:29 IST 2015
> [INFO] Final Memory: 124M/502M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/#review88344
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 387)
<https://reviews.apache.org/r/35459/#comment140820>
I think we don't need to pass `(String[])null`, varargs takes care of that automatically.
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java (line 98)
<https://reviews.apache.org/r/35459/#comment140821>
The new function can be used?
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java (line 169)
<https://reviews.apache.org/r/35459/#comment140818>
Is this change related?
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java (line 233)
<https://reviews.apache.org/r/35459/#comment140819>
Another test case for a non-dimension-only query.
- Rajat Khandelwal
On June 16, 2015, 12:45 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35459/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 12:45 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-605
> https://issues.apache.org/jira/browse/LENS-605
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes Candidate pruning wrt sourcecolumns required for joinchains
>
> - Fixes when multiple tables not reachable for a candidate. Added regression tests
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c5d8d91
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
>
> Diff: https://reviews.apache.org/r/35459/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [6.972s]
> [INFO] Lens .............................................. SUCCESS [10.815s]
> [INFO] Lens API .......................................... SUCCESS [42.589s]
> [INFO] Lens API for server and extensions ................ SUCCESS [29.129s]
> [INFO] Lens Cube ......................................... SUCCESS [5:44.521s]
> [INFO] Lens DB storage ................................... SUCCESS [39.222s]
> [INFO] Lens Query Library ................................ SUCCESS [24.951s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:46.073s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [52.714s]
> [INFO] Lens Server ....................................... SUCCESS [36:12.315s]
> [INFO] Lens client ....................................... SUCCESS [2:07.156s]
> [INFO] Lens CLI .......................................... SUCCESS [13:16.990s]
> [INFO] Lens Examples ..................................... SUCCESS [22.787s]
> [INFO] Lens Distribution ................................. SUCCESS [38.863s]
> [INFO] Lens ML Lib ....................................... SUCCESS [5:37.658s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [28.590s]
> [INFO] Lens Regression ................................... SUCCESS [25.328s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:13:07.899s
> [INFO] Finished at: Tue Jun 16 12:43:29 IST 2015
> [INFO] Final Memory: 124M/502M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/#review88745
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On June 22, 2015, 1:35 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35459/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 1:35 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-605
> https://issues.apache.org/jira/browse/LENS-605
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes Candidate pruning wrt sourcecolumns required for joinchains
>
> - Fixes when multiple tables not reachable for a candidate. Added regression tests
> - Fixed looking for dimensions required expression, existing testcases cover the changes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 33b1a62
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 3ed94fa
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
>
> Diff: https://reviews.apache.org/r/35459/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.302s]
> [INFO] Lens .............................................. SUCCESS [3.241s]
> [INFO] Lens API .......................................... SUCCESS [36.416s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.924s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.100s]
> [INFO] Lens DB storage ................................... SUCCESS [19.676s]
> [INFO] Lens Query Library ................................ SUCCESS [15.397s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:54.179s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.889s]
> [INFO] Lens Server ....................................... SUCCESS [5:44.988s]
> [INFO] Lens client ....................................... SUCCESS [35.906s]
> [INFO] Lens CLI .......................................... SUCCESS [2:33.420s]
> [INFO] Lens Examples ..................................... SUCCESS [10.690s]
> [INFO] Lens Distribution ................................. SUCCESS [8.263s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.308s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.594s]
> [INFO] Lens Regression ................................... SUCCESS [11.395s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:28.632s
> [INFO] Finished at: Mon Jun 22 07:16:26 UTC 2015
> [INFO] Final Memory: 176M/1346M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/
-----------------------------------------------------------
(Updated June 22, 2015, 8:05 a.m.)
Review request for lens and Rajat Khandelwal.
Bugs: LENS-605
https://issues.apache.org/jira/browse/LENS-605
Repository: lens
Description
-------
Fixes Candidate pruning wrt sourcecolumns required for joinchains
- Fixes when multiple tables not reachable for a candidate. Added regression tests
- Fixed looking for dimensions required expression, existing testcases cover the changes
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 33b1a62
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 3ed94fa
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
Diff: https://reviews.apache.org/r/35459/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.302s]
[INFO] Lens .............................................. SUCCESS [3.241s]
[INFO] Lens API .......................................... SUCCESS [36.416s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.924s]
[INFO] Lens Cube ......................................... SUCCESS [3:34.100s]
[INFO] Lens DB storage ................................... SUCCESS [19.676s]
[INFO] Lens Query Library ................................ SUCCESS [15.397s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.179s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.889s]
[INFO] Lens Server ....................................... SUCCESS [5:44.988s]
[INFO] Lens client ....................................... SUCCESS [35.906s]
[INFO] Lens CLI .......................................... SUCCESS [2:33.420s]
[INFO] Lens Examples ..................................... SUCCESS [10.690s]
[INFO] Lens Distribution ................................. SUCCESS [8.263s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.308s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.594s]
[INFO] Lens Regression ................................... SUCCESS [11.395s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:28.632s
[INFO] Finished at: Mon Jun 22 07:16:26 UTC 2015
[INFO] Final Memory: 176M/1346M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/
-----------------------------------------------------------
(Updated June 22, 2015, 6:58 a.m.)
Review request for lens and Rajat Khandelwal.
Changes
-------
Review comments fixed
Bugs: LENS-605
https://issues.apache.org/jira/browse/LENS-605
Repository: lens
Description
-------
Fixes Candidate pruning wrt sourcecolumns required for joinchains
- Fixes when multiple tables not reachable for a candidate. Added regression tests
- Fixed looking for dimensions required expression, existing testcases cover the changes
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 33b1a62
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 3ed94fa
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
Diff: https://reviews.apache.org/r/35459/diff/
Testing (updated)
-------
Re-running tests with latest.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.575s]
[INFO] Lens .............................................. SUCCESS [3.227s]
[INFO] Lens API .......................................... SUCCESS [22.773s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.788s]
[INFO] Lens Cube ......................................... SUCCESS [3:32.784s]
[INFO] Lens DB storage ................................... SUCCESS [19.930s]
[INFO] Lens Query Library ................................ SUCCESS [15.830s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.178s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.611s]
[INFO] Lens Server ....................................... SUCCESS [5:21.314s]
[INFO] Lens client ....................................... SUCCESS [37.142s]
[INFO] Lens CLI .......................................... SUCCESS [2:33.387s]
[INFO] Lens Examples ..................................... SUCCESS [9.229s]
[INFO] Lens Distribution ................................. SUCCESS [8.291s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.627s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.758s]
[INFO] Lens Regression ................................... SUCCESS [11.060s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:53.473s
[INFO] Finished at: Fri Jun 19 09:08:17 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On June 22, 2015, 5:52 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java, line 631
> > <https://reviews.apache.org/r/35459/diff/2/?file=988110#file988110line631>
> >
> > Do we need to add things to a set and then iterate over them separately? Can't we call `removeOptionalDim` here itself?
Yes. Otherwise it would result in ConcurrentModificationException
> On June 22, 2015, 5:52 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, line 360
> > <https://reviews.apache.org/r/35459/diff/2/?file=988111#file988111line360>
> >
> > Looks like we could use `http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/collect/HashMultimap.html`
Dropping this change suggested.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/#review88731
-----------------------------------------------------------
On June 19, 2015, 9:25 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35459/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 9:25 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-605
> https://issues.apache.org/jira/browse/LENS-605
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes Candidate pruning wrt sourcecolumns required for joinchains
>
> - Fixes when multiple tables not reachable for a candidate. Added regression tests
> - Fixed looking for dimensions required expression, existing testcases cover the changes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
>
> Diff: https://reviews.apache.org/r/35459/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.575s]
> [INFO] Lens .............................................. SUCCESS [3.227s]
> [INFO] Lens API .......................................... SUCCESS [22.773s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.788s]
> [INFO] Lens Cube ......................................... SUCCESS [3:32.784s]
> [INFO] Lens DB storage ................................... SUCCESS [19.930s]
> [INFO] Lens Query Library ................................ SUCCESS [15.830s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.178s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.611s]
> [INFO] Lens Server ....................................... SUCCESS [5:21.314s]
> [INFO] Lens client ....................................... SUCCESS [37.142s]
> [INFO] Lens CLI .......................................... SUCCESS [2:33.387s]
> [INFO] Lens Examples ..................................... SUCCESS [9.229s]
> [INFO] Lens Distribution ................................. SUCCESS [8.291s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.627s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.758s]
> [INFO] Lens Regression ................................... SUCCESS [11.060s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:53.473s
> [INFO] Finished at: Fri Jun 19 09:08:17 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/#review88731
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java (line 554)
<https://reviews.apache.org/r/35459/#comment141302>
`Fact not reachable through dim`? What does that mean?
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java (line 605)
<https://reviews.apache.org/r/35459/#comment141304>
Should we make a new prune cause for expressions?
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java (line 624)
<https://reviews.apache.org/r/35459/#comment141305>
Do we need to add things to a set and then iterate over them separately? Can't we call `removeOptionalDim` here itself?
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 360)
<https://reviews.apache.org/r/35459/#comment141306>
Looks like we could use `http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/collect/HashMultimap.html`
- Rajat Khandelwal
On June 19, 2015, 2:55 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35459/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 2:55 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-605
> https://issues.apache.org/jira/browse/LENS-605
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes Candidate pruning wrt sourcecolumns required for joinchains
>
> - Fixes when multiple tables not reachable for a candidate. Added regression tests
> - Fixed looking for dimensions required expression, existing testcases cover the changes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
>
> Diff: https://reviews.apache.org/r/35459/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.575s]
> [INFO] Lens .............................................. SUCCESS [3.227s]
> [INFO] Lens API .......................................... SUCCESS [22.773s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.788s]
> [INFO] Lens Cube ......................................... SUCCESS [3:32.784s]
> [INFO] Lens DB storage ................................... SUCCESS [19.930s]
> [INFO] Lens Query Library ................................ SUCCESS [15.830s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.178s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.611s]
> [INFO] Lens Server ....................................... SUCCESS [5:21.314s]
> [INFO] Lens client ....................................... SUCCESS [37.142s]
> [INFO] Lens CLI .......................................... SUCCESS [2:33.387s]
> [INFO] Lens Examples ..................................... SUCCESS [9.229s]
> [INFO] Lens Distribution ................................. SUCCESS [8.291s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.627s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.758s]
> [INFO] Lens Regression ................................... SUCCESS [11.060s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:53.473s
> [INFO] Finished at: Fri Jun 19 09:08:17 UTC 2015
> [INFO] Final Memory: 173M/1360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/
-----------------------------------------------------------
(Updated June 19, 2015, 9:25 a.m.)
Review request for lens and Rajat Khandelwal.
Bugs: LENS-605
https://issues.apache.org/jira/browse/LENS-605
Repository: lens
Description (updated)
-------
Fixes Candidate pruning wrt sourcecolumns required for joinchains
- Fixes when multiple tables not reachable for a candidate. Added regression tests
- Fixed looking for dimensions required expression, existing testcases cover the changes
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
Diff: https://reviews.apache.org/r/35459/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.575s]
[INFO] Lens .............................................. SUCCESS [3.227s]
[INFO] Lens API .......................................... SUCCESS [22.773s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.788s]
[INFO] Lens Cube ......................................... SUCCESS [3:32.784s]
[INFO] Lens DB storage ................................... SUCCESS [19.930s]
[INFO] Lens Query Library ................................ SUCCESS [15.830s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.178s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.611s]
[INFO] Lens Server ....................................... SUCCESS [5:21.314s]
[INFO] Lens client ....................................... SUCCESS [37.142s]
[INFO] Lens CLI .......................................... SUCCESS [2:33.387s]
[INFO] Lens Examples ..................................... SUCCESS [9.229s]
[INFO] Lens Distribution ................................. SUCCESS [8.291s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.627s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.758s]
[INFO] Lens Regression ................................... SUCCESS [11.060s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:53.473s
[INFO] Finished at: Fri Jun 19 09:08:17 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 35459: LENS-605 : Fix Candidate pruning wrt
sourcecolumns required for joinchains
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/
-----------------------------------------------------------
(Updated June 16, 2015, 7:15 a.m.)
Review request for lens and Rajat Khandelwal.
Bugs: LENS-605
https://issues.apache.org/jira/browse/LENS-605
Repository: lens
Description
-------
Fixes Candidate pruning wrt sourcecolumns required for joinchains
- Fixes when multiple tables not reachable for a candidate. Added regression tests
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 79d6d43
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c5d8d91
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 8e199ea
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java e615ccc
Diff: https://reviews.apache.org/r/35459/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [6.972s]
[INFO] Lens .............................................. SUCCESS [10.815s]
[INFO] Lens API .......................................... SUCCESS [42.589s]
[INFO] Lens API for server and extensions ................ SUCCESS [29.129s]
[INFO] Lens Cube ......................................... SUCCESS [5:44.521s]
[INFO] Lens DB storage ................................... SUCCESS [39.222s]
[INFO] Lens Query Library ................................ SUCCESS [24.951s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:46.073s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [52.714s]
[INFO] Lens Server ....................................... SUCCESS [36:12.315s]
[INFO] Lens client ....................................... SUCCESS [2:07.156s]
[INFO] Lens CLI .......................................... SUCCESS [13:16.990s]
[INFO] Lens Examples ..................................... SUCCESS [22.787s]
[INFO] Lens Distribution ................................. SUCCESS [38.863s]
[INFO] Lens ML Lib ....................................... SUCCESS [5:37.658s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [28.590s]
[INFO] Lens Regression ................................... SUCCESS [25.328s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:13:07.899s
[INFO] Finished at: Tue Jun 16 12:43:29 IST 2015
[INFO] Final Memory: 124M/502M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu