[GitHub] [kafka] vvcephei commented on a change in pull request #10452: KAFKA-12593: Fix header in streams-scala

[GitBox <gi...@apache.org>]

vvcephei commented on a change in pull request #10452:
URL: https://github.com/apache/kafka/pull/10452#discussion_r605140307



##########
File path: build.gradle
##########
@@ -46,6 +46,7 @@ spotless {
   scala {
     target 'streams/**/*.scala'
     scalafmt("$versions.scalafmt").configFile('checkstyle/.scalafmt.conf')
+    licenseHeaderFile 'checkstyle/java.header', 'package'

Review comment:
       This will enforce nothing like this happens again by applying the same check we have for Java via checkstyle.

##########
File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/FunctionConversions.scala
##########
@@ -1,7 +1,4 @@
 /*
- * Copyright (C) 2018 Lightbend Inc. <https://www.lightbend.com>
- * Copyright (C) 2017-2018 Alexis Seigneurin.
- *

Review comment:
       These were the blocks that had been wrongly added to the header.

##########
File path: NOTICE
##########
@@ -10,3 +10,7 @@ License. The source code of jersey can be found at https://github.com/jersey/jer
 This distribution has a binary test dependency on jqwik, which is available under
 the Eclipse Public License 2.0. The source code can be found at
 https://github.com/jlink/jqwik.
+
+The streams-scala (streams/streams-scala) module was donated by Lightbend and the original code was copyrighted by them:
+Copyright (C) 2018 Lightbend Inc. <https://www.lightbend.com>
+Copyright (C) 2017-2018 Alexis Seigneurin.

Review comment:
       I'm not totally comfortable just dropping those notices, so I added this note here. Not sure if it's any better, though.

##########
File path: streams/streams-scala/NOTICE
##########
@@ -1,3 +0,0 @@
-Kafka Streams Scala
-Copyright (C) 2018 Lightbend Inc. <https://www.lightbend.com>
-Copyright (C) 2017-2018 Alexis Seigneurin.

Review comment:
       I'm pretty sure there's not supposed to be extra NOTICE files in sub-directories of the project.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org