You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2014/10/20 21:13:01 UTC
Review Request 26952: ShellCommandUtil.Results class should be public,
not package private
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-7870
https://issues.apache.org/jira/browse/AMBARI-7870
Repository: ambari
Description
-------
ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
Diff: https://reviews.apache.org/r/26952/diff/
Testing
-------
Thanks,
Robert Levas
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/#review57995
-----------------------------------------------------------
Ship it!
This change looks fine to me. In the future, we may want to consider moving this class to the top-level, since it looks like it is basically part of a public-facing API.
- Robert Nettleton
On Oct. 22, 2014, 7:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26952/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 7:51 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-7870
> https://issues.apache.org/jira/browse/AMBARI-7870
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
>
> Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
>
> Diff: https://reviews.apache.org/r/26952/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/#review58111
-----------------------------------------------------------
Merged to trunk.
All unit tests pass.
Results :
Tests run: 2193, Failures: 0, Errors: 0, Skipped: 16
...
Total run:669
Total errors:0
Total failures:0
- John Speidel
On Oct. 23, 2014, 9:24 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26952/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 9:24 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-7870
> https://issues.apache.org/jira/browse/AMBARI-7870
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
>
> Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
>
> Diff: https://reviews.apache.org/r/26952/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 5:24 p.m.)
Review request for Ambari and John Speidel.
Changes
-------
Removed unnecessary import to fix warning message.
Bugs: AMBARI-7870
https://issues.apache.org/jira/browse/AMBARI-7870
Repository: ambari
Description
-------
ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
Diff: https://reviews.apache.org/r/26952/diff/
Testing
-------
Thanks,
Robert Levas
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 23, 2014, 2:25 p.m., John Speidel wrote:
> > Should this be backported to 1.7.0?
Sorry for the late reply. This is only for new features being added for 2.0.0.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/#review58042
-----------------------------------------------------------
On Oct. 23, 2014, 5:24 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26952/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 5:24 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-7870
> https://issues.apache.org/jira/browse/AMBARI-7870
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
>
> Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
>
> Diff: https://reviews.apache.org/r/26952/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/#review58042
-----------------------------------------------------------
Should this be backported to 1.7.0?
- John Speidel
On Oct. 22, 2014, 7:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26952/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 7:51 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-7870
> https://issues.apache.org/jira/browse/AMBARI-7870
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
>
> Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
>
> Diff: https://reviews.apache.org/r/26952/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/#review58039
-----------------------------------------------------------
Ship it!
Agree with Bob's comment that this should eventually be moved to a top level class.
- John Speidel
On Oct. 22, 2014, 7:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26952/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 7:51 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-7870
> https://issues.apache.org/jira/browse/AMBARI-7870
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
>
> Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
>
> Diff: https://reviews.apache.org/r/26952/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 26952: ShellCommandUtil.Results class should be public, not package private
Posted by Robert Levas <rl...@hortonworks.com>.
Please review my small change. It’s only a few lines and if it could be done by the end of this week I would be very appreciative.
Thanks
Rob
On Oct 22, 2014, at 3:51 PM, Robert Levas <rl...@hortonworks.com> wrote:
>
> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26952/
>
> Review request for Ambari and John Speidel.
> By Robert Levas.
> Updated Oct. 22, 2014, 3:51 p.m.
>
> Bugs: AMBARI-7870
> Repository: ambari
> Description
>
> ShellCommandUtil.Results class should be public, not package private. Because it is package private, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
> Solution: Make ShellCommandUtil.Results and its methods explicitly public
> Diffs
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java (ee83aa0)
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java (27a033c)
> View Diff
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 3:51 p.m.)
Review request for Ambari and John Speidel.
Bugs: AMBARI-7870
https://issues.apache.org/jira/browse/AMBARI-7870
Repository: ambari
Description
-------
ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
Diff: https://reviews.apache.org/r/26952/diff/
Testing
-------
Thanks,
Robert Levas
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/#review57525
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 20, 2014, 7:16 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26952/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 7:16 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7870
> https://issues.apache.org/jira/browse/AMBARI-7870
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
>
> Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
>
> Diff: https://reviews.apache.org/r/26952/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 3:16 p.m.)
Review request for Ambari.
Bugs: AMBARI-7870
https://issues.apache.org/jira/browse/AMBARI-7870
Repository: ambari
Description
-------
ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
Diff: https://reviews.apache.org/r/26952/diff/
Testing
-------
Thanks,
Robert Levas
Re: Review Request 26952: ShellCommandUtil.Results class should be
public, not package private
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 3:13 p.m.)
Review request for Ambari.
Bugs: AMBARI-7870
https://issues.apache.org/jira/browse/AMBARI-7870
Repository: ambari
Description
-------
ShellCommandUtil.Results class should be _public_, _not package_ private. Because it is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically unusable outside of the org.apache.ambari.server.utils package.
Solution: Make ShellCommandUtil.Results and its methods explicitly _public_
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 27a033c
Diff: https://reviews.apache.org/r/26952/diff/
Testing
-------
Thanks,
Robert Levas