You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2023/06/12 13:23:39 UTC
[myfaces-tobago] branch main updated (ac97846951 -> 0f63068c73)
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
from ac97846951 build(deps): bump guava from 32.0.0-jre to 32.0.1-jre
new 58f50b183c fix: tobago-popover
new 0f63068c73 build(theme): rebuild after fixing popover
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
tobago-theme/tobago-theme-standard/src/main/js/tobago.js | 2 +-
tobago-theme/tobago-theme-standard/src/main/js/tobago.js.map | 2 +-
tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts | 8 ++------
3 files changed, 4 insertions(+), 8 deletions(-)
[myfaces-tobago] 01/02: fix: tobago-popover
Posted by hn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit 58f50b183c637c01bd3fc202f9e3b8e9acd20801
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Mon Jun 12 14:41:31 2023 +0200
fix: tobago-popover
By default the messagePosition is buttonRight. If an error message occur on a form component, a button with a tobago-popover should displayed on the right side. With the current Chrome(v114) and the current Edge(v114), this button is noch visible anymore. In the older version of Edge(v112) or with Firefox(v114) the button is shown.
It seems that the newer Chrome/Edge browser has activated this feature https://developer.mozilla.org/en-US/docs/Web/CSS/:popover-open
With this feature some styles are set on a [popover] which hide the message button.
Issue: TOBAGO-2232
---
tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts b/tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts
index 4a1b83167b..49cec5300c 100644
--- a/tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts
+++ b/tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts
@@ -15,10 +15,6 @@
* limitations under the License.
*/
-// XXX which? nothing works...
-// import * as bootstrap from "bootstrap/dist/js/bootstrap";
-// import Popover from "bootstrap/dist/js/bootstrap.bundle";
-// import {createPopper} from "@popperjs/core/dist/esm/popper";
import {Popover} from "bootstrap";
import {MenuStore} from "./tobago-menu-store";
@@ -26,14 +22,14 @@ import {MenuStore} from "./tobago-menu-store";
class TobagoPopover extends HTMLElement {
- private popover: Popover;
+ private instance: Popover;
constructor() {
super();
}
connectedCallback(): void {
- this.popover = new Popover(this.trigger, {
+ this.instance = new Popover(this.trigger, {
container: MenuStore.get()
});
}
[myfaces-tobago] 02/02: build(theme): rebuild after fixing popover
Posted by hn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit 0f63068c738245f0ff1c5812468068a102df8df3
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Mon Jun 12 15:13:25 2023 +0200
build(theme): rebuild after fixing popover
---
tobago-theme/tobago-theme-standard/src/main/js/tobago.js | 2 +-
tobago-theme/tobago-theme-standard/src/main/js/tobago.js.map | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tobago-theme/tobago-theme-standard/src/main/js/tobago.js b/tobago-theme/tobago-theme-standard/src/main/js/tobago.js
index 55eb8488f3..b216432080 100644
--- a/tobago-theme/tobago-theme-standard/src/main/js/tobago.js
+++ b/tobago-theme/tobago-theme-standard/src/main/js/tobago.js
@@ -4,7 +4,7 @@
* Copyright 2011-2023 The Bootstrap Authors (https://github.com/twbs/bootstrap/graphs/contributors)
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/main/LICENSE)
*/
-const Re=new Map,Me={set(e,t,s){Re.has(e)||Re.set(e,new Map);const n=Re.get(e);n.has(t)||0===n.size?n.set(t,s):console.error(`Bootstrap doesn't allow more than one instance per element. Bound instance: ${Array.from(n.keys())[0]}.`)},get:(e,t)=>Re.has(e)&&Re.get(e).get(t)||null,remove(e,t){if(!Re.has(e))return;const s=Re.get(e);s.delete(t),0===s.size&&Re.delete(e)}},Pe="transitionend",Be=e=>(e&&window.CSS&&window.CSS.escape&&(e=e.replace(/#([^\s"#']+)/g,((e,t)=>`#${CSS.escape(t)}`))),e),H [...]
+const Re=new Map,Me={set(e,t,s){Re.has(e)||Re.set(e,new Map);const n=Re.get(e);n.has(t)||0===n.size?n.set(t,s):console.error(`Bootstrap doesn't allow more than one instance per element. Bound instance: ${Array.from(n.keys())[0]}.`)},get:(e,t)=>Re.has(e)&&Re.get(e).get(t)||null,remove(e,t){if(!Re.has(e))return;const s=Re.get(e);s.delete(t),0===s.size&&Re.delete(e)}},Pe="transitionend",Be=e=>(e&&window.CSS&&window.CSS.escape&&(e=e.replace(/#([^\s"#']+)/g,((e,t)=>`#${CSS.escape(t)}`))),e),H [...]
/**
* @license
* Copyright 2017 Google LLC
diff --git a/tobago-theme/tobago-theme-standard/src/main/js/tobago.js.map b/tobago-theme/tobago-theme-standard/src/main/js/tobago.js.map
index d8dd560412..d9383a1743 100644
--- a/tobago-theme/tobago-theme-standard/src/main/js/tobago.js.map
+++ b/tobago-theme/tobago-theme-standard/src/main/js/tobago.js.map
@@ -1 +1 @@
-{"version":3,"file":"tobago.js","sources":["../ts/tobago-css.ts","../ts/tobago-bar.ts","../../../../node_modules/@popperjs/core/lib/enums.js","../../../../node_modules/@popperjs/core/lib/dom-utils/getNodeName.js","../../../../node_modules/@popperjs/core/lib/dom-utils/getWindow.js","../../../../node_modules/@popperjs/core/lib/dom-utils/instanceOf.js","../../../../node_modules/@popperjs/core/lib/modifiers/applyStyles.js","../../../../node_modules/@popperjs/core/lib/utils/getBasePlacement.j [...]
\ No newline at end of file
+{"version":3,"file":"tobago.js","sources":["../ts/tobago-css.ts","../ts/tobago-bar.ts","../../../../node_modules/@popperjs/core/lib/enums.js","../../../../node_modules/@popperjs/core/lib/dom-utils/getNodeName.js","../../../../node_modules/@popperjs/core/lib/dom-utils/getWindow.js","../../../../node_modules/@popperjs/core/lib/dom-utils/instanceOf.js","../../../../node_modules/@popperjs/core/lib/modifiers/applyStyles.js","../../../../node_modules/@popperjs/core/lib/utils/getBasePlacement.j [...]
\ No newline at end of file