You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/05 22:23:17 UTC
[GitHub] [hudi] lamber-ken opened a new pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
lamber-ken opened a new pull request #1706:
URL: https://github.com/apache/hudi/pull/1706
## What is the purpose of the pull request
Based on #1698, if folks don't want to build staging site by themself, we can introduce a rebot which build testing website automatically.
Use command `sync testing site`, the rebot will fetch the repository and build site, then push the test site https://apachehudi.github.io/hudi-testing-site
## Brief change log
- Introduce a robot to build testing website automatically
## Verify this pull request
https://github.com/lamber-ken/hconfig/pull/7
https://apachehudi.github.io/hudi-testing-site
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#discussion_r438898007
##########
File path: .github/workflows/web.yml
##########
@@ -0,0 +1,51 @@
+name: web sync
+
+on:
+ issue_comment:
+ types: [created]
+
+jobs:
+ bot:
+ runs-on: ubuntu-latest
+ if: ${{ github.event.comment.body == 'sync testing site' }}
+
+ steps:
+ - name: clone repository
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
+
+ - name: fetch pull request branch
+ run: |
+ git fetch origin +refs/pull/${{ github.event.issue.number }}/merge
+ git checkout FETCH_HEAD
+
+ siteRef=`git show-ref --hash --verify refs/remotes/origin/asf-site`
+ pullRef=`git log -1 --pretty=format:"%P" -1`
+ if [[ $pullRef =~ $siteRef ]]
+ then
+ exit 0;
+ else
+ exit -1;
Review comment:
What effect does a -1 signal have ? Will it kill the build ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
n3nash commented on pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#issuecomment-655265702
@lamber-ken any updates on this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#issuecomment-768866751
we need this ultimately.
@lamber-ken we miss you man. where have you been? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
n3nash commented on pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#issuecomment-810749309
@lamberken Are you able to pick this one up ? If not, let me know if it's ok for us to take it over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#discussion_r438898630
##########
File path: .github/workflows/web.yml
##########
@@ -0,0 +1,51 @@
+name: web sync
+
+on:
+ issue_comment:
+ types: [created]
+
+jobs:
+ bot:
+ runs-on: ubuntu-latest
+ if: ${{ github.event.comment.body == 'sync testing site' }}
+
+ steps:
+ - name: clone repository
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
+
+ - name: fetch pull request branch
+ run: |
+ git fetch origin +refs/pull/${{ github.event.issue.number }}/merge
+ git checkout FETCH_HEAD
+
+ siteRef=`git show-ref --hash --verify refs/remotes/origin/asf-site`
+ pullRef=`git log -1 --pretty=format:"%P" -1`
+ if [[ $pullRef =~ $siteRef ]]
+ then
+ exit 0;
+ else
+ exit -1;
+ fi
+
+ - name: jekyll docker build
+ run: |
+ docker run \
+ --privileged=true \
+ -v ${{ github.workspace }}/docs:/srv/jekyll/docs \
+ -v ${{ github.workspace }}/_site:/srv/jekyll/docs/_site \
+ jekyll/jekyll:3.8 \
+ /bin/bash -c "chmod 777 -R /srv/jekyll && cd /srv/jekyll/docs && gem sources -l && bundle install && bundle exec jekyll build --config _config.yml,_config.testing.yml"
+
+ - name: push test site
+ run: |
+ git clone https://${{ secrets.HUDI_GITHUB_WEB_TOKEN }}@github.com/ApacheHudi/hudi-testing-site
Review comment:
Do we already have this branch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar closed pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
vinothchandar closed pull request #1706:
URL: https://github.com/apache/hudi/pull/1706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#discussion_r438897508
##########
File path: .github/workflows/web.yml
##########
@@ -0,0 +1,51 @@
+name: web sync
+
+on:
+ issue_comment:
+ types: [created]
+
+jobs:
+ bot:
+ runs-on: ubuntu-latest
+ if: ${{ github.event.comment.body == 'sync testing site' }}
+
+ steps:
+ - name: clone repository
+ uses: actions/checkout@v2
Review comment:
What does checkout@v2 mean ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#discussion_r438898007
##########
File path: .github/workflows/web.yml
##########
@@ -0,0 +1,51 @@
+name: web sync
+
+on:
+ issue_comment:
+ types: [created]
+
+jobs:
+ bot:
+ runs-on: ubuntu-latest
+ if: ${{ github.event.comment.body == 'sync testing site' }}
+
+ steps:
+ - name: clone repository
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
+
+ - name: fetch pull request branch
+ run: |
+ git fetch origin +refs/pull/${{ github.event.issue.number }}/merge
+ git checkout FETCH_HEAD
+
+ siteRef=`git show-ref --hash --verify refs/remotes/origin/asf-site`
+ pullRef=`git log -1 --pretty=format:"%P" -1`
+ if [[ $pullRef =~ $siteRef ]]
+ then
+ exit 0;
+ else
+ exit -1;
Review comment:
What effect does a -1 signal have ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#issuecomment-768748851
@lamber-ken : are you planning to work on this.
@n3nash : do we need this, or close it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#issuecomment-640409433
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1706?src=pr&el=h1) Report
> Merging [#1706](https://codecov.io/gh/apache/hudi/pull/1706?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/fb283934a33a0bc7b11f80e4149f7922fa4f0af5&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1706?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1706 +/- ##
============================================
+ Coverage 18.19% 18.24% +0.05%
- Complexity 857 863 +6
============================================
Files 348 348
Lines 15358 15391 +33
Branches 1525 1525
============================================
+ Hits 2794 2808 +14
- Misses 12206 12225 +19
Partials 358 358
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1706?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...i/common/table/view/HoodieTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/1706/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `39.56% <0.00%> (+1.62%)` | `15.00% <0.00%> (+6.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1706?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1706?src=pr&el=footer). Last update [fb28393...ea5e06b](https://codecov.io/gh/apache/hudi/pull/1706?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #1706: [HUDI-998] Introduce a robot to build testing website automatically
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1706:
URL: https://github.com/apache/hudi/pull/1706#discussion_r438897242
##########
File path: .github/workflows/web.yml
##########
@@ -0,0 +1,51 @@
+name: web sync
Review comment:
@lamber-ken how does this web.yml get triggered ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org