You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Claus Ibsen <cl...@gmail.com> on 2008/11/22 11:30:40 UTC
Checkstyle enabled
Hi
Checkstyle has been enabled when doing maven install and now I have a
catch-22 situation.
It want's that a field in HttpOperationFailedException should be
declared final but it can not, as it's optional and there is a setter
for it.
[INFO] Starting audit...
D:\project\camel\components\camel-http\src\main\java\org\apache\camel\component\http\HttpOperationFailedException.java:29:5:
The field 'responseBody' must be declared final.
Audit done.
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
Re: Checkstyle enabled
Posted by James Strachan <ja...@gmail.com>.
2008/12/1 Jonathan Anstey <ja...@gmail.com>:
> Agreed.
>
> I've disabled checkstyle by default. Pass in -Psourcecheck to enable it :)
Yay! :)
--
James
-------
http://macstrac.blogspot.com/
Open Source Integration
http://fusesource.com/
Re: Checkstyle enabled
Posted by Jonathan Anstey <ja...@gmail.com>.
I added a little info on the "Building" wiki page.
Claus Ibsen wrote:
> Hi Jon
>
> Do you mind add a few lines on the wiki somewhere with building the
> source etc. how to enable this checkstyle. As I would like to try to
> run it before doing bigger commits to spare willem and others.
> But I kinda forget all the maven profiles that is out there.
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>
>
>
> On Mon, Dec 1, 2008 at 9:11 PM, Jonathan Anstey <ja...@gmail.com> wrote:
>
>> Agreed.
>>
>> I've disabled checkstyle by default. Pass in -Psourcecheck to enable it :)
>>
>> James Strachan wrote:
>>
>>> 2008/12/1 James Strachan <ja...@gmail.com>:
>>>
>>>
>>>> 2008/12/1 Claus Ibsen <cl...@gmail.com>:
>>>>
>>>>
>>>>> Hi
>>>>>
>>>>> No me neither. I used to have the CXF checkstyle format that is
>>>>> somewhere in the camel code as a .jar file you can import in IDEA.
>>>>>
>>>>> What I have not is it to be configured with the correct import order
>>>>> so I can optimize imports. But the only pita is the auto import
>>>>> on-the-fly will insert it at the wrong place
>>>>> so you have to optimize it from time to time.
>>>>>
>>>>> Otherwise I think William is happy with it turned on, as it saves a
>>>>> lot of his work to fix and commit code ;)
>>>>>
>>>>> I am not a maven hog, but I guess there is some parameter you can add
>>>>> to skip it. Jon / William?
>>>>>
>>>>>
>>>> IMHO if folks using IDEA can't develop code efficiently (i.e. manually
>>>> having to frig with the code to get past checkstyle rules) - I'd say
>>>> the checkstyle plugin is of limited value anyway - whether its
>>>> mandatory or optional.
>>>>
>>>>
>>> I'd much rather have lots of folks contributing to Camel - than having
>>> folks turning away in frustration at having their IDE put some imports
>>> in the wrong order or adding the odd extra space here or there. Having
>>> lots of happy contributors far outweighs use of whitespace & imports
>>> ordering IMHO!
>>>
>>>
>>>
>>
Re: Checkstyle enabled
Posted by Claus Ibsen <cl...@gmail.com>.
Hi Jon
Do you mind add a few lines on the wiki somewhere with building the
source etc. how to enable this checkstyle. As I would like to try to
run it before doing bigger commits to spare willem and others.
But I kinda forget all the maven profiles that is out there.
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Mon, Dec 1, 2008 at 9:11 PM, Jonathan Anstey <ja...@gmail.com> wrote:
> Agreed.
>
> I've disabled checkstyle by default. Pass in -Psourcecheck to enable it :)
>
> James Strachan wrote:
>>
>> 2008/12/1 James Strachan <ja...@gmail.com>:
>>
>>>
>>> 2008/12/1 Claus Ibsen <cl...@gmail.com>:
>>>
>>>>
>>>> Hi
>>>>
>>>> No me neither. I used to have the CXF checkstyle format that is
>>>> somewhere in the camel code as a .jar file you can import in IDEA.
>>>>
>>>> What I have not is it to be configured with the correct import order
>>>> so I can optimize imports. But the only pita is the auto import
>>>> on-the-fly will insert it at the wrong place
>>>> so you have to optimize it from time to time.
>>>>
>>>> Otherwise I think William is happy with it turned on, as it saves a
>>>> lot of his work to fix and commit code ;)
>>>>
>>>> I am not a maven hog, but I guess there is some parameter you can add
>>>> to skip it. Jon / William?
>>>>
>>>
>>> IMHO if folks using IDEA can't develop code efficiently (i.e. manually
>>> having to frig with the code to get past checkstyle rules) - I'd say
>>> the checkstyle plugin is of limited value anyway - whether its
>>> mandatory or optional.
>>>
>>
>> I'd much rather have lots of folks contributing to Camel - than having
>> folks turning away in frustration at having their IDE put some imports
>> in the wrong order or adding the odd extra space here or there. Having
>> lots of happy contributors far outweighs use of whitespace & imports
>> ordering IMHO!
>>
>>
>
>
Re: Checkstyle enabled
Posted by Jonathan Anstey <ja...@gmail.com>.
Agreed.
I've disabled checkstyle by default. Pass in -Psourcecheck to enable it :)
James Strachan wrote:
> 2008/12/1 James Strachan <ja...@gmail.com>:
>
>> 2008/12/1 Claus Ibsen <cl...@gmail.com>:
>>
>>> Hi
>>>
>>> No me neither. I used to have the CXF checkstyle format that is
>>> somewhere in the camel code as a .jar file you can import in IDEA.
>>>
>>> What I have not is it to be configured with the correct import order
>>> so I can optimize imports. But the only pita is the auto import
>>> on-the-fly will insert it at the wrong place
>>> so you have to optimize it from time to time.
>>>
>>> Otherwise I think William is happy with it turned on, as it saves a
>>> lot of his work to fix and commit code ;)
>>>
>>> I am not a maven hog, but I guess there is some parameter you can add
>>> to skip it. Jon / William?
>>>
>> IMHO if folks using IDEA can't develop code efficiently (i.e. manually
>> having to frig with the code to get past checkstyle rules) - I'd say
>> the checkstyle plugin is of limited value anyway - whether its
>> mandatory or optional.
>>
>
> I'd much rather have lots of folks contributing to Camel - than having
> folks turning away in frustration at having their IDE put some imports
> in the wrong order or adding the odd extra space here or there. Having
> lots of happy contributors far outweighs use of whitespace & imports
> ordering IMHO!
>
>
Re: Checkstyle enabled
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
Yeah I found a old picture (= me looking younger) as my avatar profile ;)
Ah ok its only 2 years old.
Well I have not programmed with "papers with holes" ( Hollerith cards
) so I am not old nor young ;)
My first job as a educated engineer was to program on the AS400 with
the RPG programming language.
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Tue, Dec 2, 2008 at 2:36 PM, Hadrian Zbarcea <hz...@gmail.com> wrote:
> I thought Claus is younger :)
> Hadrian
>
> On Dec 1, 2008, at 3:11 PM, Claus Ibsen wrote:
>
>> Hi
>>
>> Yeah I remeber the old days with Pascal and Delpi when that Hungarian
>> notations was forced as company policy. Damm that was unpleasant.
>>
>> And personally I dislike when the code is auto wrapped to be aligned
>> with 80/100 or 120 chars wide.
>> Kinda dull to read code where the method name is on the next line
>>
>> xxxxxxxxxxxxxxxxxxx.
>> methodHere()
>>
>> So if the checkstyle could stop doing that then I am happy with it
>> report of missing copyrights and whatelse I might miss.
>>
>>
>> /Claus Ibsen
>> Apache Camel Committer
>> Blog: http://davsclaus.blogspot.com/
>>
>>
>>
>> On Mon, Dec 1, 2008 at 8:53 PM, James Strachan <ja...@gmail.com>
>> wrote:
>>>
>>> 2008/12/1 James Strachan <ja...@gmail.com>:
>>>>
>>>> 2008/12/1 Claus Ibsen <cl...@gmail.com>:
>>>>>
>>>>> Hi
>>>>>
>>>>> No me neither. I used to have the CXF checkstyle format that is
>>>>> somewhere in the camel code as a .jar file you can import in IDEA.
>>>>>
>>>>> What I have not is it to be configured with the correct import order
>>>>> so I can optimize imports. But the only pita is the auto import
>>>>> on-the-fly will insert it at the wrong place
>>>>> so you have to optimize it from time to time.
>>>>>
>>>>> Otherwise I think William is happy with it turned on, as it saves a
>>>>> lot of his work to fix and commit code ;)
>>>>>
>>>>> I am not a maven hog, but I guess there is some parameter you can add
>>>>> to skip it. Jon / William?
>>>>
>>>> IMHO if folks using IDEA can't develop code efficiently (i.e. manually
>>>> having to frig with the code to get past checkstyle rules) - I'd say
>>>> the checkstyle plugin is of limited value anyway - whether its
>>>> mandatory or optional.
>>>
>>> I'd much rather have lots of folks contributing to Camel - than having
>>> folks turning away in frustration at having their IDE put some imports
>>> in the wrong order or adding the odd extra space here or there. Having
>>> lots of happy contributors far outweighs use of whitespace & imports
>>> ordering IMHO!
>>>
>>> --
>>> James
>>> -------
>>> http://macstrac.blogspot.com/
>>>
>>> Open Source Integration
>>> http://fusesource.com/
>>>
>
>
Re: Checkstyle enabled
Posted by Hadrian Zbarcea <hz...@gmail.com>.
I thought Claus is younger :)
Hadrian
On Dec 1, 2008, at 3:11 PM, Claus Ibsen wrote:
> Hi
>
> Yeah I remeber the old days with Pascal and Delpi when that Hungarian
> notations was forced as company policy. Damm that was unpleasant.
>
> And personally I dislike when the code is auto wrapped to be aligned
> with 80/100 or 120 chars wide.
> Kinda dull to read code where the method name is on the next line
>
> xxxxxxxxxxxxxxxxxxx.
> methodHere()
>
> So if the checkstyle could stop doing that then I am happy with it
> report of missing copyrights and whatelse I might miss.
>
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>
>
>
> On Mon, Dec 1, 2008 at 8:53 PM, James Strachan <james.strachan@gmail.com
> > wrote:
>> 2008/12/1 James Strachan <ja...@gmail.com>:
>>> 2008/12/1 Claus Ibsen <cl...@gmail.com>:
>>>> Hi
>>>>
>>>> No me neither. I used to have the CXF checkstyle format that is
>>>> somewhere in the camel code as a .jar file you can import in IDEA.
>>>>
>>>> What I have not is it to be configured with the correct import
>>>> order
>>>> so I can optimize imports. But the only pita is the auto import
>>>> on-the-fly will insert it at the wrong place
>>>> so you have to optimize it from time to time.
>>>>
>>>> Otherwise I think William is happy with it turned on, as it saves a
>>>> lot of his work to fix and commit code ;)
>>>>
>>>> I am not a maven hog, but I guess there is some parameter you can
>>>> add
>>>> to skip it. Jon / William?
>>>
>>> IMHO if folks using IDEA can't develop code efficiently (i.e.
>>> manually
>>> having to frig with the code to get past checkstyle rules) - I'd say
>>> the checkstyle plugin is of limited value anyway - whether its
>>> mandatory or optional.
>>
>> I'd much rather have lots of folks contributing to Camel - than
>> having
>> folks turning away in frustration at having their IDE put some
>> imports
>> in the wrong order or adding the odd extra space here or there.
>> Having
>> lots of happy contributors far outweighs use of whitespace & imports
>> ordering IMHO!
>>
>> --
>> James
>> -------
>> http://macstrac.blogspot.com/
>>
>> Open Source Integration
>> http://fusesource.com/
>>
Re: Checkstyle enabled
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
Yeah I remeber the old days with Pascal and Delpi when that Hungarian
notations was forced as company policy. Damm that was unpleasant.
And personally I dislike when the code is auto wrapped to be aligned
with 80/100 or 120 chars wide.
Kinda dull to read code where the method name is on the next line
xxxxxxxxxxxxxxxxxxx.
methodHere()
So if the checkstyle could stop doing that then I am happy with it
report of missing copyrights and whatelse I might miss.
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Mon, Dec 1, 2008 at 8:53 PM, James Strachan <ja...@gmail.com> wrote:
> 2008/12/1 James Strachan <ja...@gmail.com>:
>> 2008/12/1 Claus Ibsen <cl...@gmail.com>:
>>> Hi
>>>
>>> No me neither. I used to have the CXF checkstyle format that is
>>> somewhere in the camel code as a .jar file you can import in IDEA.
>>>
>>> What I have not is it to be configured with the correct import order
>>> so I can optimize imports. But the only pita is the auto import
>>> on-the-fly will insert it at the wrong place
>>> so you have to optimize it from time to time.
>>>
>>> Otherwise I think William is happy with it turned on, as it saves a
>>> lot of his work to fix and commit code ;)
>>>
>>> I am not a maven hog, but I guess there is some parameter you can add
>>> to skip it. Jon / William?
>>
>> IMHO if folks using IDEA can't develop code efficiently (i.e. manually
>> having to frig with the code to get past checkstyle rules) - I'd say
>> the checkstyle plugin is of limited value anyway - whether its
>> mandatory or optional.
>
> I'd much rather have lots of folks contributing to Camel - than having
> folks turning away in frustration at having their IDE put some imports
> in the wrong order or adding the odd extra space here or there. Having
> lots of happy contributors far outweighs use of whitespace & imports
> ordering IMHO!
>
> --
> James
> -------
> http://macstrac.blogspot.com/
>
> Open Source Integration
> http://fusesource.com/
>
Re: Checkstyle enabled
Posted by James Strachan <ja...@gmail.com>.
2008/12/1 James Strachan <ja...@gmail.com>:
> 2008/12/1 Claus Ibsen <cl...@gmail.com>:
>> Hi
>>
>> No me neither. I used to have the CXF checkstyle format that is
>> somewhere in the camel code as a .jar file you can import in IDEA.
>>
>> What I have not is it to be configured with the correct import order
>> so I can optimize imports. But the only pita is the auto import
>> on-the-fly will insert it at the wrong place
>> so you have to optimize it from time to time.
>>
>> Otherwise I think William is happy with it turned on, as it saves a
>> lot of his work to fix and commit code ;)
>>
>> I am not a maven hog, but I guess there is some parameter you can add
>> to skip it. Jon / William?
>
> IMHO if folks using IDEA can't develop code efficiently (i.e. manually
> having to frig with the code to get past checkstyle rules) - I'd say
> the checkstyle plugin is of limited value anyway - whether its
> mandatory or optional.
I'd much rather have lots of folks contributing to Camel - than having
folks turning away in frustration at having their IDE put some imports
in the wrong order or adding the odd extra space here or there. Having
lots of happy contributors far outweighs use of whitespace & imports
ordering IMHO!
--
James
-------
http://macstrac.blogspot.com/
Open Source Integration
http://fusesource.com/
Re: Checkstyle enabled
Posted by James Strachan <ja...@gmail.com>.
2008/12/1 Claus Ibsen <cl...@gmail.com>:
> Hi
>
> No me neither. I used to have the CXF checkstyle format that is
> somewhere in the camel code as a .jar file you can import in IDEA.
>
> What I have not is it to be configured with the correct import order
> so I can optimize imports. But the only pita is the auto import
> on-the-fly will insert it at the wrong place
> so you have to optimize it from time to time.
>
> Otherwise I think William is happy with it turned on, as it saves a
> lot of his work to fix and commit code ;)
>
> I am not a maven hog, but I guess there is some parameter you can add
> to skip it. Jon / William?
IMHO if folks using IDEA can't develop code efficiently (i.e. manually
having to frig with the code to get past checkstyle rules) - I'd say
the checkstyle plugin is of limited value anyway - whether its
mandatory or optional.
--
James
-------
http://macstrac.blogspot.com/
Open Source Integration
http://fusesource.com/
Re: Checkstyle enabled
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
No me neither. I used to have the CXF checkstyle format that is
somewhere in the camel code as a .jar file you can import in IDEA.
What I have not is it to be configured with the correct import order
so I can optimize imports. But the only pita is the auto import
on-the-fly will insert it at the wrong place
so you have to optimize it from time to time.
Otherwise I think William is happy with it turned on, as it saves a
lot of his work to fix and commit code ;)
I am not a maven hog, but I guess there is some parameter you can add
to skip it. Jon / William?
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Mon, Dec 1, 2008 at 8:36 PM, James Strachan <ja...@gmail.com> wrote:
> BTW until someone can figure out an easy way to get IDEA to format
> code according to the checkstyle settings - I think we should disable
> it by default.
>
> Has anyone figured out how to get IDEA to play nice? I tried following
> the instructions, using the checkstyle plugin for IDEA - but checking
> the style is totally different from configuring the code style that
> the IDE uses when reformatting files.
>
>
> 2008/11/22 Claus Ibsen <cl...@gmail.com>:
>> Hi
>>
>> Checkstyle has been enabled when doing maven install and now I have a
>> catch-22 situation.
>>
>> It want's that a field in HttpOperationFailedException should be
>> declared final but it can not, as it's optional and there is a setter
>> for it.
>>
>> [INFO] Starting audit...
>> D:\project\camel\components\camel-http\src\main\java\org\apache\camel\component\http\HttpOperationFailedException.java:29:5:
>> The field 'responseBody' must be declared final.
>> Audit done.
>>
>> /Claus Ibsen
>> Apache Camel Committer
>> Blog: http://davsclaus.blogspot.com/
>>
>
>
>
> --
> James
> -------
> http://macstrac.blogspot.com/
>
> Open Source Integration
> http://fusesource.com/
>
Re: Checkstyle enabled
Posted by James Strachan <ja...@gmail.com>.
BTW until someone can figure out an easy way to get IDEA to format
code according to the checkstyle settings - I think we should disable
it by default.
Has anyone figured out how to get IDEA to play nice? I tried following
the instructions, using the checkstyle plugin for IDEA - but checking
the style is totally different from configuring the code style that
the IDE uses when reformatting files.
2008/11/22 Claus Ibsen <cl...@gmail.com>:
> Hi
>
> Checkstyle has been enabled when doing maven install and now I have a
> catch-22 situation.
>
> It want's that a field in HttpOperationFailedException should be
> declared final but it can not, as it's optional and there is a setter
> for it.
>
> [INFO] Starting audit...
> D:\project\camel\components\camel-http\src\main\java\org\apache\camel\component\http\HttpOperationFailedException.java:29:5:
> The field 'responseBody' must be declared final.
> Audit done.
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>
--
James
-------
http://macstrac.blogspot.com/
Open Source Integration
http://fusesource.com/
Re: Checkstyle enabled
Posted by Willem Jiang <wi...@gmail.com>.
Sure, I'm working on this, it should be done after I run a quick test.
Willem
On Sat, Nov 22, 2008 at 9:53 PM, Claus Ibsen <cl...@gmail.com> wrote:
> Hi William
>
> Great could you do it on the 1.x branch as well?
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>
>
>
> On Sat, Nov 22, 2008 at 2:22 PM, Willem Jiang <wi...@gmail.com>
> wrote:
> > Hi Claus,
> >
> > I just fixed these CS Errors, if you don't mind I will commit the fix
> > patch in a minute :)
> >
> > Willem
> >
> > Claus Ibsen wrote:
> >> Hi
> >>
> >> I have refactored the code so the responsebody is a constructor
> >> parameter so it can be final.
> >>
> >> And I will fix the other checkstyle errors of missing apache licenses.
> >> Sorry IDEA hides these ;)
> >>
> >> /Claus Ibsen
> >> Apache Camel Committer
> >> Blog: http://davsclaus.blogspot.com/
> >>
> >>
> >>
> >> On Sat, Nov 22, 2008 at 11:30 AM, Claus Ibsen <cl...@gmail.com>
> wrote:
> >>> Hi
> >>>
> >>> Checkstyle has been enabled when doing maven install and now I have a
> >>> catch-22 situation.
> >>>
> >>> It want's that a field in HttpOperationFailedException should be
> >>> declared final but it can not, as it's optional and there is a setter
> >>> for it.
> >>>
> >>> [INFO] Starting audit...
> >>>
> D:\project\camel\components\camel-http\src\main\java\org\apache\camel\component\http\HttpOperationFailedException.java:29:5:
> >>> The field 'responseBody' must be declared final.
> >>> Audit done.
> >>>
> >>> /Claus Ibsen
> >>> Apache Camel Committer
> >>> Blog: http://davsclaus.blogspot.com/
> >>>
> >>
> >
> >
>
Re: Checkstyle enabled
Posted by Claus Ibsen <cl...@gmail.com>.
Hi William
Great could you do it on the 1.x branch as well?
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Sat, Nov 22, 2008 at 2:22 PM, Willem Jiang <wi...@gmail.com> wrote:
> Hi Claus,
>
> I just fixed these CS Errors, if you don't mind I will commit the fix
> patch in a minute :)
>
> Willem
>
> Claus Ibsen wrote:
>> Hi
>>
>> I have refactored the code so the responsebody is a constructor
>> parameter so it can be final.
>>
>> And I will fix the other checkstyle errors of missing apache licenses.
>> Sorry IDEA hides these ;)
>>
>> /Claus Ibsen
>> Apache Camel Committer
>> Blog: http://davsclaus.blogspot.com/
>>
>>
>>
>> On Sat, Nov 22, 2008 at 11:30 AM, Claus Ibsen <cl...@gmail.com> wrote:
>>> Hi
>>>
>>> Checkstyle has been enabled when doing maven install and now I have a
>>> catch-22 situation.
>>>
>>> It want's that a field in HttpOperationFailedException should be
>>> declared final but it can not, as it's optional and there is a setter
>>> for it.
>>>
>>> [INFO] Starting audit...
>>> D:\project\camel\components\camel-http\src\main\java\org\apache\camel\component\http\HttpOperationFailedException.java:29:5:
>>> The field 'responseBody' must be declared final.
>>> Audit done.
>>>
>>> /Claus Ibsen
>>> Apache Camel Committer
>>> Blog: http://davsclaus.blogspot.com/
>>>
>>
>
>
Re: Checkstyle enabled
Posted by Willem Jiang <wi...@gmail.com>.
Hi Claus,
I just fixed these CS Errors, if you don't mind I will commit the fix
patch in a minute :)
Willem
Claus Ibsen wrote:
> Hi
>
> I have refactored the code so the responsebody is a constructor
> parameter so it can be final.
>
> And I will fix the other checkstyle errors of missing apache licenses.
> Sorry IDEA hides these ;)
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>
>
>
> On Sat, Nov 22, 2008 at 11:30 AM, Claus Ibsen <cl...@gmail.com> wrote:
>> Hi
>>
>> Checkstyle has been enabled when doing maven install and now I have a
>> catch-22 situation.
>>
>> It want's that a field in HttpOperationFailedException should be
>> declared final but it can not, as it's optional and there is a setter
>> for it.
>>
>> [INFO] Starting audit...
>> D:\project\camel\components\camel-http\src\main\java\org\apache\camel\component\http\HttpOperationFailedException.java:29:5:
>> The field 'responseBody' must be declared final.
>> Audit done.
>>
>> /Claus Ibsen
>> Apache Camel Committer
>> Blog: http://davsclaus.blogspot.com/
>>
>
Re: Checkstyle enabled
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
I have refactored the code so the responsebody is a constructor
parameter so it can be final.
And I will fix the other checkstyle errors of missing apache licenses.
Sorry IDEA hides these ;)
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Sat, Nov 22, 2008 at 11:30 AM, Claus Ibsen <cl...@gmail.com> wrote:
> Hi
>
> Checkstyle has been enabled when doing maven install and now I have a
> catch-22 situation.
>
> It want's that a field in HttpOperationFailedException should be
> declared final but it can not, as it's optional and there is a setter
> for it.
>
> [INFO] Starting audit...
> D:\project\camel\components\camel-http\src\main\java\org\apache\camel\component\http\HttpOperationFailedException.java:29:5:
> The field 'responseBody' must be declared final.
> Audit done.
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>