You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/03/25 21:42:13 UTC
[Bug 6388] New: Patch to allow administrator control over failure to
retrieve userprefs from LDAP or SQL
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6388
Summary: Patch to allow administrator control over failure to
retrieve userprefs from LDAP or SQL
Product: Spamassassin
Version: 3.3.1
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: kdeugau@vianet.ca
Created an attachment (id=4720)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4720)
Make SQL and LDAP userpref errors behave the same, add admin toggle to control
failure mode
In doing some testing for MySQL failover, I found that SQL userprefs hard-fail
(return the message unprocessed) if any SQL error occurs.
While digging into the code to see if I could make this soft-fail (continue
processing with global prefs), I also found that LDAP userprefs do pretty much
what I was looking for.
Patch attached to make both LDAP and SQL behave the same by default
(soft-fail), as well as adding an admin option to cause a hard-fail (Just In
Case someone really wants to do that).
The patch applies cleanly to trunk @ r927586 as well as 3.3.1.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6388] Patch to allow administrator control over failure to
retrieve userprefs from LDAP or SQL
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6388
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
Target Milestone|Undefined |3.4.0
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6388] Patch to allow administrator control over failure to
retrieve userprefs from LDAP or SQL
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6388
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4720|0 |1
is obsolete| |
--- Comment #1 from Mark Martinec <Ma...@ijs.si> ---
Created attachment 5136
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=5136&action=edit
let's try with this
Essentially the original change, but only logs at the info level (not warning)
if a global fallback is enabled. Some naming changes for consistency between
both modules and other similar modules.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6388] Patch to allow administrator control over failure to
retrieve userprefs from LDAP or SQL
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6388
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Mark Martinec <Ma...@ijs.si> ---
Closing, looks resolved - but not confirmed.
Please re-open if necessary.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6388] Patch to allow administrator control over failure to
retrieve userprefs from LDAP or SQL
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6388
--- Comment #2 from Mark Martinec <Ma...@ijs.si> ---
trunk:
Bug 6388: Patch to allow administrator control over failure
to retrieve userprefs from LDAP or SQL
Sending lib/Mail/SpamAssassin/Conf/LDAP.pm
Sending lib/Mail/SpamAssassin/Conf/SQL.pm
Sending lib/Mail/SpamAssassin/Conf.pm
Committed revision 1451317.
--
You are receiving this mail because:
You are the assignee for the bug.