You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2020/01/23 01:08:29 UTC

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15093


Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................

IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3

test_kudu_table_create_without_hms fails when using Hive3. The test
failure leaves the minicluster in a wired state since it restarts Hive
to use a different configuration. Skip this test until it's fixed.

Tests:
 - Run test_kudu_table_create_without_hms.py and verify it's skipped.

Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
---
M tests/common/skip.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
2 files changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/15093/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15093 )

Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5502/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 01:53:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15093 )

Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Thanks for putting this together!

http://gerrit.cloudera.org:8080/#/c/15093/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15093/1//COMMIT_MSG@10
PS1, Line 10: wired
Nit: weird



-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 01:36:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15093

to look at the new patch set (#2).

Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................

IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3

test_kudu_table_create_without_hms fails when using Hive3. The test
failure leaves the minicluster in a weird state since it restarts Hive
to use a different configuration. Skip this test until it's fixed.

Tests:
 - Run test_kudu_table_create_without_hms.py and verify it's skipped.

Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
---
M tests/common/skip.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/15093/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15093 )

Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 02:31:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15093 )

Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................

IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3

test_kudu_table_create_without_hms fails when using Hive3. The test
failure leaves the minicluster in a weird state since it restarts Hive
to use a different configuration. Skip this test until it's fixed.

Tests:
 - Run test_kudu_table_create_without_hms.py and verify it's skipped.

Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Reviewed-on: http://gerrit.cloudera.org:8080/15093
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/skip.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15093 )

Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5456/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 02:31:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15093 )

Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 07:19:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Skip test kudu table create without hms in Hive3

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15093 )

Change subject: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 2: Code-Review+2

Carry +2 from Joe


-- 
To view, visit http://gerrit.cloudera.org:8080/15093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
Gerrit-Change-Number: 15093
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 02:30:09 +0000
Gerrit-HasComments: No