You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by Ben Laurie <be...@hyperreal.com> on 1997/06/29 19:29:18 UTC

cvs commit: apache/src http_core.c

ben         97/06/29 10:29:18

  Modified:    src       http_core.c
  Log:
  Fix warnings in VC++.
  
  Revision  Changes    Path
  1.88      +2 -2      apache/src/http_core.c
  
  Index: http_core.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/http_core.c,v
  retrieving revision 1.87
  retrieving revision 1.88
  diff -C3 -r1.87 -r1.88
  *** http_core.c	1997/06/28 23:57:55	1.87
  --- http_core.c	1997/06/29 17:29:17	1.88
  ***************
  *** 506,512 ****
    
    const char *set_options (cmd_parms *cmd, core_dir_config *d, const char *l)
    {
  !     char opt;
        int first = 1;
        char action;
    
  --- 506,512 ----
    
    const char *set_options (cmd_parms *cmd, core_dir_config *d, const char *l)
    {
  !     unsigned char opt;
        int first = 1;
        char action;
    
  ***************
  *** 1145,1151 ****
    {
        listen_rec *new;
        char *ports;
  !     unsigned port;
    
        if (cmd->server->is_virtual) return "Listen not allowed in <VirtualHost>";
        ports=strchr(ips, ':');
  --- 1145,1151 ----
    {
        listen_rec *new;
        char *ports;
  !     unsigned short port;
    
        if (cmd->server->is_virtual) return "Listen not allowed in <VirtualHost>";
        ports=strchr(ips, ':');
  
  
  

Re: cvs commit: apache/src http_core.c

Posted by Dean Gaudet <dg...@arctic.org>.
Do you have some totally anal option turned on?  The change to ports below
is bogus imho.

The change to opt is also bogus, but I'm about to commit a patch to fix
that.  There's an allow_options_t defined in http_core.h which should be
used.

Dean

On Sun, 29 Jun 1997, Ben Laurie wrote:

> ben         97/06/29 10:29:18
> 
>   Modified:    src       http_core.c
>   Log:
>   Fix warnings in VC++.
>   
>   Revision  Changes    Path
>   1.88      +2 -2      apache/src/http_core.c
>   
>   Index: http_core.c
>   ===================================================================
>   RCS file: /export/home/cvs/apache/src/http_core.c,v
>   retrieving revision 1.87
>   retrieving revision 1.88
>   diff -C3 -r1.87 -r1.88
>   *** http_core.c	1997/06/28 23:57:55	1.87
>   --- http_core.c	1997/06/29 17:29:17	1.88
>   ***************
>   *** 506,512 ****
>     
>     const char *set_options (cmd_parms *cmd, core_dir_config *d, const char *l)
>     {
>   !     char opt;
>         int first = 1;
>         char action;
>     
>   --- 506,512 ----
>     
>     const char *set_options (cmd_parms *cmd, core_dir_config *d, const char *l)
>     {
>   !     unsigned char opt;
>         int first = 1;
>         char action;
>     
>   ***************
>   *** 1145,1151 ****
>     {
>         listen_rec *new;
>         char *ports;
>   !     unsigned port;
>     
>         if (cmd->server->is_virtual) return "Listen not allowed in <VirtualHost>";
>         ports=strchr(ips, ':');
>   --- 1145,1151 ----
>     {
>         listen_rec *new;
>         char *ports;
>   !     unsigned short port;
>     
>         if (cmd->server->is_virtual) return "Listen not allowed in <VirtualHost>";
>         ports=strchr(ips, ':');
>   
>   
>   
>