[GitHub] [geode] Bill opened pull request #2818: GEODE-5993: Eliminate race in monitorQueryThread()

["Bill (GitHub)" <gi...@apache.org>]

A race existed between setting low memory in the heap monitor thread,
and checking the low memory state in query monitoring thread.

The cancelation executor was shut down and no longer accepting new
tasks when this race occurred, causing a RejectedExecutionException.

This commit solves that problem by encapsulating the scheduling
behavior using the state design pattern.

Co-authored-by: Ryan McMahon <rm...@pivotal.io>
Co-authored-by: Bill Burcham <bb...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- N/A If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2818 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #2818: GEODE-5993: Eliminate race in monitorQueryThread()

["Bill (GitHub)" <gi...@apache.org>]

DUnit tests passed in previous run except for a known issue.

Integration tests failed in previous run due to global problem (on `develop` branch). That's since been fixed (we think).

Rerunning tests now with the goal of seeing integration tests pass 💚 

[ Full content available at: https://github.com/apache/geode/pull/2818 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #2818: GEODE-5993: Eliminate race in monitorQueryThread()

["mcmellawatt (GitHub)" <gi...@apache.org>]

[ pull request closed by mcmellawatt ]

[ Full content available at: https://github.com/apache/geode/pull/2818 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org