You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "EarthChen (via GitHub)" <gi...@apache.org> on 2023/03/07 09:18:12 UTC
[GitHub] [dubbo] EarthChen commented on a diff in pull request #11756: metrics dependencies change
EarthChen commented on code in PR #11756:
URL: https://github.com/apache/dubbo/pull/11756#discussion_r1127568023
##########
dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilderTest.java:
##########
@@ -49,7 +49,7 @@ protected Result doInvoke(Invocation invocation) {
};
Invoker<?> invokerAfterBuild = defaultFilterChainBuilder.buildInvokerChain(invokerWithoutFilter, REFERENCE_FILTER_KEY, CONSUMER);
- Assertions.assertTrue(invokerAfterBuild instanceof AbstractInvoker);
+// Assertions.assertTrue(invokerAfterBuild instanceof AbstractInvoker);
Review Comment:
remove unused code
##########
dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilderTest.java:
##########
@@ -84,7 +84,7 @@ protected Result doInvoke(Invocation invocation) {
};
Invoker<?> invokerAfterBuild = defaultFilterChainBuilder.buildInvokerChain(invokerWithoutFilter, REFERENCE_FILTER_KEY, CONSUMER);
- Assertions.assertTrue(invokerAfterBuild instanceof AbstractInvoker);
+// Assertions.assertTrue(invokerAfterBuild instanceof AbstractInvoker);
Review Comment:
some
##########
dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/filter/DefaultFilterChainBuilderTest.java:
##########
@@ -64,7 +64,7 @@ protected Result doInvoke(Invocation invocation) {
};
invokerAfterBuild = defaultFilterChainBuilder.buildInvokerChain(invokerWithFilter, REFERENCE_FILTER_KEY, CONSUMER);
Assertions.assertTrue(invokerAfterBuild instanceof FilterChainBuilder.CallbackRegistrationInvoker);
- Assertions.assertEquals(1, ((FilterChainBuilder.CallbackRegistrationInvoker<?, ?>) invokerAfterBuild).filters.size());
+// Assertions.assertEquals(1, ((FilterChainBuilder.CallbackRegistrationInvoker<?, ?>) invokerAfterBuild).filters.size());
Review Comment:
some
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org