You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Andrew Spencer (JIRA)" <ji...@apache.org> on 2010/11/16 14:20:13 UTC
[jira] Created: (CXF-3129) wsdl2java: place @Generated annotation
on generated code
wsdl2java: place @Generated annotation on generated code
--------------------------------------------------------
Key: CXF-3129
URL: https://issues.apache.org/jira/browse/CXF-3129
Project: CXF
Issue Type: New Feature
Components: Tooling
Affects Versions: 2.3.0
Reporter: Andrew Spencer
Priority: Minor
It would be considerate on the part of CXF to place @Generated on the Java source generated by wsdl2java.
@Generated is in the javax.annotation package and is a marker for generated code. It allows code quality tools to ignore the generated code, as described in this feature request for Sonar: http://jira.codehaus.org/browse/SONAR-1042
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-3129) wsdl2java: place @Generated annotation
on generated code
Posted by "Andrew Spencer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977195#action_12977195 ]
Andrew Spencer commented on CXF-3129:
-------------------------------------
Thanks to both of you for your work on this issue.
> wsdl2java: place @Generated annotation on generated code
> --------------------------------------------------------
>
> Key: CXF-3129
> URL: https://issues.apache.org/jira/browse/CXF-3129
> Project: CXF
> Issue Type: New Feature
> Components: Tooling
> Affects Versions: 2.3.0
> Reporter: Andrew Spencer
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: Patch for CXF 3129 - version 2.patch, Patch for CXF 3129.txt
>
>
> It would be considerate on the part of CXF to place @Generated on the Java source generated by wsdl2java.
> @Generated is in the javax.annotation package and is a marker for generated code. It allows code quality tools to ignore the generated code, as described in this feature request for Sonar: http://jira.codehaus.org/browse/SONAR-1042
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-3129) wsdl2java: place @Generated annotation
on generated code
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp resolved CXF-3129.
------------------------------
Resolution: Fixed
Fix Version/s: 2.3.2
Patch applied.
I did fix the unit test as well as added the CXF version in the comments field of the class level annotation. Everything looked good though. Thanks!
> wsdl2java: place @Generated annotation on generated code
> --------------------------------------------------------
>
> Key: CXF-3129
> URL: https://issues.apache.org/jira/browse/CXF-3129
> Project: CXF
> Issue Type: New Feature
> Components: Tooling
> Affects Versions: 2.3.0
> Reporter: Andrew Spencer
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: Patch for CXF 3129 - version 2.patch, Patch for CXF 3129.txt
>
>
> It would be considerate on the part of CXF to place @Generated on the Java source generated by wsdl2java.
> @Generated is in the javax.annotation package and is a marker for generated code. It allows code quality tools to ignore the generated code, as described in this feature request for Sonar: http://jira.codehaus.org/browse/SONAR-1042
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-3129) wsdl2java: place @Generated annotation
on generated code
Posted by "Nithya Sivasubramaniam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nithya Sivasubramaniam updated CXF-3129:
----------------------------------------
Attachment: Patch for CXF 3129 - version 2.patch
(1) Added a new option, '-mark-generated' to wsdl2java, as discussed in the dev mailing list. When this option is set, all generated java files will have @Generated annotation set on classes, fields, constructors and methods.
(1.1) Passes the mark-generated flag to jaxb xjc so that all classes generated by jaxb include the annotation.
(1.2) Modified velocity templates to support adding the mark-generated flag for classes directly generated by CXF.
(2) Added CodeGenOptionTest.testMarkGeneratedOption() that exercises the new -mark-generated option. This test requires a newer version of jaxb xjc (version 2.2.3). So the test is commented out and should be uncommented once we move to using the newer version of jaxb.
> wsdl2java: place @Generated annotation on generated code
> --------------------------------------------------------
>
> Key: CXF-3129
> URL: https://issues.apache.org/jira/browse/CXF-3129
> Project: CXF
> Issue Type: New Feature
> Components: Tooling
> Affects Versions: 2.3.0
> Reporter: Andrew Spencer
> Priority: Minor
> Attachments: Patch for CXF 3129 - version 2.patch, Patch for CXF 3129.txt
>
>
> It would be considerate on the part of CXF to place @Generated on the Java source generated by wsdl2java.
> @Generated is in the javax.annotation package and is a marker for generated code. It allows code quality tools to ignore the generated code, as described in this feature request for Sonar: http://jira.codehaus.org/browse/SONAR-1042
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-3129) wsdl2java: place @Generated annotation
on generated code
Posted by "Nithya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nithya updated CXF-3129:
------------------------
Attachment: Patch for CXF 3129.txt
> wsdl2java: place @Generated annotation on generated code
> --------------------------------------------------------
>
> Key: CXF-3129
> URL: https://issues.apache.org/jira/browse/CXF-3129
> Project: CXF
> Issue Type: New Feature
> Components: Tooling
> Affects Versions: 2.3.0
> Reporter: Andrew Spencer
> Priority: Minor
> Attachments: Patch for CXF 3129.txt
>
>
> It would be considerate on the part of CXF to place @Generated on the Java source generated by wsdl2java.
> @Generated is in the javax.annotation package and is a marker for generated code. It allows code quality tools to ignore the generated code, as described in this feature request for Sonar: http://jira.codehaus.org/browse/SONAR-1042
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CXF-3129) wsdl2java: place @Generated annotation
on generated code
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp reassigned CXF-3129:
--------------------------------
Assignee: Daniel Kulp
> wsdl2java: place @Generated annotation on generated code
> --------------------------------------------------------
>
> Key: CXF-3129
> URL: https://issues.apache.org/jira/browse/CXF-3129
> Project: CXF
> Issue Type: New Feature
> Components: Tooling
> Affects Versions: 2.3.0
> Reporter: Andrew Spencer
> Assignee: Daniel Kulp
> Priority: Minor
> Attachments: Patch for CXF 3129 - version 2.patch, Patch for CXF 3129.txt
>
>
> It would be considerate on the part of CXF to place @Generated on the Java source generated by wsdl2java.
> @Generated is in the javax.annotation package and is a marker for generated code. It allows code quality tools to ignore the generated code, as described in this feature request for Sonar: http://jira.codehaus.org/browse/SONAR-1042
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-3129) wsdl2java: place @Generated annotation
on generated code
Posted by "Nithya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969625#action_12969625 ]
Nithya commented on CXF-3129:
-----------------------------
Made changes in 2 places
1. Passing -mark-generated attribute to XJC
2. Changes in velocity templates
> wsdl2java: place @Generated annotation on generated code
> --------------------------------------------------------
>
> Key: CXF-3129
> URL: https://issues.apache.org/jira/browse/CXF-3129
> Project: CXF
> Issue Type: New Feature
> Components: Tooling
> Affects Versions: 2.3.0
> Reporter: Andrew Spencer
> Priority: Minor
> Attachments: Patch for CXF 3129.txt
>
>
> It would be considerate on the part of CXF to place @Generated on the Java source generated by wsdl2java.
> @Generated is in the javax.annotation package and is a marker for generated code. It allows code quality tools to ignore the generated code, as described in this feature request for Sonar: http://jira.codehaus.org/browse/SONAR-1042
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.