[GitHub] [kafka] wcarlson5 commented on a change in pull request #11334: KAFKA-13246: StoreQueryIntegrationTest#shouldQueryStoresAfterAddingAn…

[GitBox <gi...@apache.org>]

wcarlson5 commented on a change in pull request #11334:
URL: https://github.com/apache/kafka/pull/11334#discussion_r713141647



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java
##########
@@ -477,6 +477,7 @@ public void shouldQueryStoresAfterAddingAndRemovingStreamThread() throws Excepti
         //Add thread
         final Optional<String> streamThread = kafkaStreams1.addStreamThread();
         assertThat(streamThread.isPresent(), is(true));
+        until(() -> kafkaStreams1.state().isRunningOrRebalancing());

Review comment:
       It is true that we are waiting for state below, however the way we are doing so causes some exceptions due to streams being in the wrong state. These exceptions are really not the point of any of the tests in this file. So how we have gotten around that was white listing exception messages. It would be better just to wait for the correct state before trying do do any IQ, like what is done here. @andy0x01 the isolation of the add remove is a nice benefit as well. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org