You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/09/08 22:12:54 UTC

[kudu-CR] KUDU-2671 allow a range to have empty hash schema

Hello Mahesh Reddy, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17825

to look at the new patch set (#5).

Change subject: KUDU-2671 allow a range to have empty hash schema
......................................................................

KUDU-2671 allow a range to have empty hash schema

With this patch, the semantics of an empty hash schema for a range
changes.  Now an empty per-range hash schema means no hash bucketing for
the range.  Prior to this patch, an empty hash schema for a range meant
using the table-wide hash schema.

The new semantics are better because:
  * they allow for having ranges with no hash bucketing even if there is
    a non-trivial hash bucketing at the table-wide level
  * they are less surprising to a user of the client API

This patch updates several test cases to account for the change and
adds a new test case to cover the new functionality.

Change-Id: Ia43df69ecd7040e285e098fde49d84a7a00d1fbb
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/integration-tests/table_locations-itest.cc
10 files changed, 271 insertions(+), 268 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/17825/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17825
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia43df69ecd7040e285e098fde49d84a7a00d1fbb
Gerrit-Change-Number: 17825
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>