You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by balidani <gi...@git.apache.org> on 2015/02/15 20:04:53 UTC

[GitHub] flink pull request: [FLINK-1528] Added local clustering coefficien...

GitHub user balidani opened a pull request:

    https://github.com/apache/flink/pull/400

    [FLINK-1528] Added local clustering coefficient example (failing)

    As @vasia requested, here is the current version of local clustering coefficient for Gelly. It causes exceptions, so this PR is only a draft.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/balidani/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #400
    
----
commit c2b19492932e1fe4f8ade1319d8dd4786bfc257e
Author: Daniel Bali <ba...@gmail.com>
Date:   2015-02-13T11:35:50Z

    [FLINK-1528] Added local clustering coefficient example (failing)

commit 39f88893ecf47dbcab3f1057f526bbf014c3086f
Author: Gyula Fora <gy...@apache.org>
Date:   2015-02-11T13:19:22Z

    [FLINK-1517] [streaming] Added indexed input iterator for streaming

commit c519ddfc64bc33474f6b8575fc051a50ab7fb0e5
Author: mbalassi <mb...@apache.org>
Date:   2015-02-12T21:20:14Z

    [streaming] Added ITCase for streaming classloading

commit 7c35e748f1b17fe86c7faea4712f673fecbeea8f
Author: Henry Saputra <he...@gmail.com>
Date:   2015-02-13T17:09:26Z

    Small cleanups to add space between if-else keyword and parentheses to be consistent
    as I found them.
    
    Also fix some comments typos."

commit b0d4e94a709e40a38bba778dd32b97c72a407d06
Author: Stephan Ewen <se...@apache.org>
Date:   2015-02-11T18:01:41Z

    [FLINK-1529] [jobmanager] Improve error handling on JobManager startup
    
    This closes #385

commit 7d5aa836e9af88b46957e08986073db3fa4a7ef6
Author: Stephan Ewen <se...@apache.org>
Date:   2015-02-13T11:22:35Z

    [FLINK-1532] [tests] Fix spurious failure in AggregatorsITCase (plus minor cleanups)

commit aeaa82c7a874a8e65c3615e3b4872c80dc426a6b
Author: Till Rohrmann <tr...@apache.org>
Date:   2015-02-10T11:21:33Z

    [FLINK-1508] [runtime] Removes AkkaUtil.ask and replaces respective calls with explicit future handling.
    
    Removes blocking calls for ActorRef retrieval in actors.
    
    This closes #384.

commit 2052be6d864b0d163b3212ed20625a77399029df
Author: Till Rohrmann <tr...@apache.org>
Date:   2015-02-12T10:49:09Z

    [FLINK-1543] [runtime] Adds try and catch blocks around all method calls from an actor's receive method which can throw an exception. Sets the StoppingSupervisorStrategy as default for all guardians.
    
    This closes #394.

commit 1162266a270a3c4508393073bf27dc8c5a656ed2
Author: Chiwan Park <ch...@icloud.com>
Date:   2015-02-08T06:36:19Z

    [FLINK-1179] [jobmanager] Add button to JobManager web interface to request stack trace of a TaskManager
    
    This closes #374

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1528] Added local clustering coefficien...

Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/400#issuecomment-74527767
  
    Right, so let me copy:
    
    The problem is here:
    ```
    DataSet<Tuple2<K, HashSet<K>>> neighborhoods = input.reduceOnEdges(new NeighborhoodEdgesFunction<K>(), EdgeDirection.OUT);
    ```
    
    and we try to get the return type `Tuple2<K, HashSet<K>>` like this:
    
    ```
    public TypeInformation<T> getProducedType() {
        return TypeExtractor.createTypeInfo(EdgesFunction.class, function.getClass(), 2, null, null);
    }
    ```
    
    Anyone have an idea? Is it because of the nested type parameter in `Tuple2<K, HashSet<K>>` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1528] Added local clustering coefficien...

Posted by balidani <gi...@git.apache.org>.
Github user balidani commented on the pull request:

    https://github.com/apache/flink/pull/400#issuecomment-74505722
  
    Hi!
    
    Sorry for the messed up commit history, hopefully my next PR will be better.
    
    I have the following exception when running `LocalClusteringCoefficientExample`
    
        Exception in thread "main" org.apache.flink.api.common.functions.InvalidTypesException: 
        Type of TypeVariable 'K' in 'class flink.graphs.library.LocalClusteringCoefficient
        $NeighborhoodEdgesFunction' could not be determined. 
        This is most likely a type erasure problem. The type extraction currently supports types 
        with generic variables only in cases where all variables in the return type can be deduced 
        from the input type(s).
    
    I have no idea how to fix this though. For anyone else reading this, here's @vasia's reply from the old `flink-graph` thread: https://github.com/project-flink/flink-graph/pull/48#issuecomment-70472784


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1528] Added local clustering coefficien...

Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/400#issuecomment-74493011
  
    Hi @balidani! Thanks for the PR. The commit history is a bit messed up, but we'll fix that. It's just the last commit that's relevant, right?
    
    If I recall correctly, you are having some type issues. Could you please give us some details on what is the error you are getting and what seems to be causing it? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1528] Added local clustering coefficien...

Posted by balidani <gi...@git.apache.org>.
Github user balidani closed the pull request at:

    https://github.com/apache/flink/pull/400


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---