You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "sabir-akhadov-localstack (via GitHub)" <gi...@apache.org> on 2026/09/01 08:57:20 UTC
[PR] Snowflake: Add ALTER EXTERNAL VOLUME [datafusion-sqlparser-rs]
sabir-akhadov-localstack opened a new pull request, #2474:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2474
Snowflake's `ALTER EXTERNAL VOLUME` did not parse:
```sql
ALTER EXTERNAL VOLUME my_vol ADD STORAGE_LOCATION = (
NAME = 'loc2' STORAGE_PROVIDER = 'S3' STORAGE_BASE_URL = 's3://bucket2/');
ALTER EXTERNAL VOLUME my_vol SET ALLOW_WRITES = TRUE;
ALTER EXTERNAL VOLUME my_vol REMOVE STORAGE_LOCATION 'loc1';
```
This adds an `AlterExternalVolume` statement with the three documented operations (`ADD STORAGE_LOCATION`, `SET ALLOW_WRITES`, `REMOVE STORAGE_LOCATION`). The added storage location reuses the same generic `KeyValueOptions` parsing as `CREATE EXTERNAL VOLUME`. All statements round-trip.
See the [Snowflake `ALTER EXTERNAL VOLUME` docs](https://docs.snowflake.com/en/sql-reference/sql/alter-external-volume).
Split out of #2397 per review feedback, alongside the CREATE/DROP (#2397), DESC (#2472), and SHOW (#2473) PRs.
**Stacked on #2397** (it reuses the storage-location parsing helper introduced there) — only the last commit is new. Kept as a draft until #2397 merges, then it will be rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Add ALTER EXTERNAL VOLUME [datafusion-sqlparser-rs]
Posted by "sabir-akhadov-localstack (via GitHub)" <gi...@apache.org>.
sabir-akhadov-localstack commented on PR #2474:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2474#issuecomment-6447681212
Rebased on latest main, so the conflicts are resolved and the `needs rebasing` label can be dropped. This one is stacked on #2475 (CREATE/DROP EXTERNAL VOLUME), so it's best reviewed after that one. @LucaCappelletti94, no rush, whenever you get to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Add ALTER EXTERNAL VOLUME [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2474:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2474#issuecomment-6298707291
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `80.95238%` with `24 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.32%. Comparing base ([`3330dc9`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/3330dc9e7ca73930a32d069d4c0338dea470b40f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a1737`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/b8a1737431e9ff36f276a7cc5772a56eb907dd50?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [src/dialect/snowflake.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?src=pr&el=tree&filepath=src%2Fdialect%2Fsnowflake.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2RpYWxlY3Qvc25vd2ZsYWtlLnJz) | 79.16% | [0 Missing and 15 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/ast/mod.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?src=pr&el=tree&filepath=src%2Fast%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2FzdC9tb2QucnM=) | 87.75% | [1 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/ast/spans.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?src=pr&el=tree&filepath=src%2Fast%2Fspans.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2FzdC9zcGFucy5ycw==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/parser/mod.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?src=pr&el=tree&filepath=src%2Fparser%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3BhcnNlci9tb2QucnM=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2474 +/- ##
========================================
Coverage 81.31% 81.32%
========================================
Files 42 42
Lines 33977 34102 +125
Branches 33977 34102 +125
========================================
+ Hits 27628 27733 +105
- Misses 2785 2786 +1
- Partials 3564 3583 +19
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2474?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org