You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/27 23:58:00 UTC
[jira] [Commented] (DRILL-6364) WebUI does not cleanly handle
shutdown and state toggling when Drillbits go on and offline
[ https://issues.apache.org/jira/browse/DRILL-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457232#comment-16457232 ]
ASF GitHub Bot commented on DRILL-6364:
---------------------------------------
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1241
DRILL-6364: Handle Cluster Info in WebUI when existing/new bits restart
As a follow up to DRILL-6289, the following improvements have been done:
1. When loading the page for the first time, the WebUI enables the shutdown button without actually checking the state of the Drillbits.
The ideal behaviour should be to disable the button till the state is verified. **[Done]**
_If a Drillbit is confirmed down (i.e. not in `/state` response), it is marked as OFFLINE and button is disabled._
2. When shutting down the current Drillbit, the WebUI no more has access to the cluster state.
The ideal behaviour here should be to fetch the state from any of the other Drillbits to update the status. **[Done]**
_With the current Drillbit down, the other bits are requested for cluster state info and update accordingly._
3. When a new, previously unseen Drillbit comes up, the WebUI will never render it because the table is statically generated during the first page load.
The idea behaviour should be to append to the table on discovery of a new node. **[Done]**
_The new Drillbit info is injected and a prompt appears to refresh the page to re-populate any missing info. This also works with feature (2) mentioned above._
The only Java code change was to have the state response carry the address and http-port as a tuple, instead of the user-port (which seems to be never used).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-6364
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1241
----
commit ab3e8619c6259803eb362be290a3a3605839a194
Author: Kunal Khatua <ku...@...>
Date: 2018-04-27T23:27:45Z
DRILL-6364: Handle Cluster Info in WebUI when existing/new bits restart
As a follow up to DRILL-6289, the following improvements have been done:
1. When loading the page for the first time, the WebUI enables the shutdown button without actually checking the state of the Drillbits.
The ideal behaviour should be to disable the button till the state is verified. [Done]
If a Drillbit is confirmed down (i.e. not in `/state` response), it is marked as OFFLINE and button is disabled.
2. When shutting down the current Drillbit, the WebUI no more has access to the cluster state.
The ideal behaviour here should be to fetch the state from any of the other Drillbits to update the status. [Done]
With the current Drillbit down, the other bits are requested for cluster state info and update accordingly.
3. When a new, previously unseen Drillbit comes up, the WebUI will never render it because the table is statically generated during the first page load.
The idea behaviour should be to append to the table on discovery of a new node. [Done]
The new Drillbit info is injected and a prompt appears to refresh the page to re-populate any missing info. This also works with feature (2) mentioned above.
The only Java code change was to have the state response carry the address and http-port as a tuple, instead of the user-port (which is never used).
----
> WebUI does not cleanly handle shutdown and state toggling when Drillbits go on and offline
> ------------------------------------------------------------------------------------------
>
> Key: DRILL-6364
> URL: https://issues.apache.org/jira/browse/DRILL-6364
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Major
> Fix For: 1.14.0
>
>
> When the webpage is loaded the first time, the shutdown button is enabled by default, which might not be correct, since scenarios like HTTPS, etc does not support this for remote bits. (i.e the user needs to navigate to that node's UI for shutting it down).
> Similarly, when a previously unseen Drillbit comes online, the node will not be rendered until the page is refreshed by the user.
> Lastly, if the node from whom the UI page was served goes down, the status update for the rest of the cluster is not updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)