You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by evans-ye <gi...@git.apache.org> on 2018/08/09 17:23:18 UTC

[GitHub] bigtop pull request #374: Add support ubuntu 18.04

Github user evans-ye commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/374#discussion_r209012845
  
    --- Diff: bigtop_toolchain/bin/puppetize.sh ---
    @@ -26,7 +26,7 @@ case ${ID}-${VERSION_ID} in
           dnf -y check-update
           dnf -y install hostname findutils curl sudo unzip wget puppet puppetlabs-stdlib
             ;;
    -    ubuntu-16.04)
    +    ubuntu-1[6,8].04)
    --- End diff --
    
    +1. Having another paragraph yield better readably.


---