You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pegasus.apache.org by zh...@apache.org on 2021/08/30 10:11:33 UTC
[incubator-pegasus] branch master updated: feat(split): add table
level split reject counters (#804)
This is an automated email from the ASF dual-hosted git repository.
zhaoliwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pegasus.git
The following commit(s) were added to refs/heads/master by this push:
new 6f339fa feat(split): add table level split reject counters (#804)
6f339fa is described below
commit 6f339faf2fd1b34553f466e9e4ceb47eed0ee3c9
Author: HeYuchen <he...@xiaomi.com>
AuthorDate: Mon Aug 30 18:11:24 2021 +0800
feat(split): add table level split reject counters (#804)
---
rdsn | 2 +-
src/server/info_collector.cpp | 2 ++
src/server/info_collector.h | 4 ++++
src/shell/command_helper.h | 8 ++++++++
src/shell/commands/table_management.cpp | 2 ++
5 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/rdsn b/rdsn
index 2b7cbf5..6135e45 160000
--- a/rdsn
+++ b/rdsn
@@ -1 +1 @@
-Subproject commit 2b7cbf5294fbfd05b0b3eda68a60292916cb6370
+Subproject commit 6135e4596a36bb7d303a8703f6c4ab15a14fedb8
diff --git a/src/server/info_collector.cpp b/src/server/info_collector.cpp
index c7f2a84..601bf51 100644
--- a/src/server/info_collector.cpp
+++ b/src/server/info_collector.cpp
@@ -220,6 +220,8 @@ info_collector::app_stat_counters *info_collector::get_app_counters(const std::s
INIT_COUNTER(recent_read_throttling_reject_count);
INIT_COUNTER(recent_backup_request_throttling_delay_count);
INIT_COUNTER(recent_backup_request_throttling_reject_count);
+ INIT_COUNTER(recent_write_splitting_reject_count);
+ INIT_COUNTER(recent_read_splitting_reject_count);
INIT_COUNTER(storage_mb);
INIT_COUNTER(storage_count);
INIT_COUNTER(rdb_block_cache_hit_rate);
diff --git a/src/server/info_collector.h b/src/server/info_collector.h
index a9e8ab0..a077cd4 100644
--- a/src/server/info_collector.h
+++ b/src/server/info_collector.h
@@ -80,6 +80,8 @@ public:
row_stats.recent_backup_request_throttling_delay_count);
recent_backup_request_throttling_reject_count->set(
row_stats.recent_backup_request_throttling_reject_count);
+ recent_write_splitting_reject_count->set(row_stats.recent_write_splitting_reject_count);
+ recent_read_splitting_reject_count->set(row_stats.recent_read_splitting_reject_count);
storage_mb->set(row_stats.storage_mb);
storage_count->set(row_stats.storage_count);
rdb_block_cache_hit_rate->set(convert_to_1M_ratio(
@@ -149,6 +151,8 @@ public:
::dsn::perf_counter_wrapper recent_read_throttling_reject_count;
::dsn::perf_counter_wrapper recent_backup_request_throttling_delay_count;
::dsn::perf_counter_wrapper recent_backup_request_throttling_reject_count;
+ ::dsn::perf_counter_wrapper recent_write_splitting_reject_count;
+ ::dsn::perf_counter_wrapper recent_read_splitting_reject_count;
::dsn::perf_counter_wrapper storage_mb;
::dsn::perf_counter_wrapper storage_count;
::dsn::perf_counter_wrapper rdb_block_cache_hit_rate;
diff --git a/src/shell/command_helper.h b/src/shell/command_helper.h
index c6364a4..fd80f1d 100644
--- a/src/shell/command_helper.h
+++ b/src/shell/command_helper.h
@@ -627,6 +627,8 @@ struct row_data
row.recent_backup_request_throttling_delay_count;
recent_backup_request_throttling_reject_count +=
row.recent_backup_request_throttling_reject_count;
+ recent_write_splitting_reject_count += row.recent_write_splitting_reject_count;
+ recent_read_splitting_reject_count += row.recent_read_splitting_reject_count;
storage_mb += row.storage_mb;
storage_count += row.storage_count;
rdb_block_cache_hit_count += row.rdb_block_cache_hit_count;
@@ -684,6 +686,8 @@ struct row_data
double recent_read_throttling_reject_count = 0;
double recent_backup_request_throttling_delay_count = 0;
double recent_backup_request_throttling_reject_count = 0;
+ double recent_write_splitting_reject_count = 0;
+ double recent_read_splitting_reject_count = 0;
double storage_mb = 0;
double storage_count = 0;
double rdb_block_cache_hit_count = 0;
@@ -766,6 +770,10 @@ update_app_pegasus_perf_counter(row_data &row, const std::string &counter_name,
row.recent_backup_request_throttling_delay_count += value;
else if (counter_name == "recent.backup.request.throttling.reject.count")
row.recent_backup_request_throttling_reject_count += value;
+ else if (counter_name == "recent.write.splitting.reject.count")
+ row.recent_write_splitting_reject_count += value;
+ else if (counter_name == "recent.read.splitting.reject.count")
+ row.recent_read_splitting_reject_count += value;
else if (counter_name == "disk.storage.sst(MB)")
row.storage_mb += value;
else if (counter_name == "disk.storage.sst.count")
diff --git a/src/shell/commands/table_management.cpp b/src/shell/commands/table_management.cpp
index 272b5d8..1c74649 100644
--- a/src/shell/commands/table_management.cpp
+++ b/src/shell/commands/table_management.cpp
@@ -511,6 +511,8 @@ bool app_stat(command_executor *e, shell_context *sc, arguments args)
row.recent_backup_request_throttling_delay_count;
sum.recent_backup_request_throttling_reject_count +=
row.recent_backup_request_throttling_reject_count;
+ sum.recent_write_splitting_reject_count += row.recent_write_splitting_reject_count;
+ sum.recent_read_splitting_reject_count += row.recent_read_splitting_reject_count;
sum.storage_mb += row.storage_mb;
sum.storage_count += row.storage_count;
sum.rdb_block_cache_hit_count += row.rdb_block_cache_hit_count;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pegasus.apache.org
For additional commands, e-mail: commits-help@pegasus.apache.org