You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by cowtowncoder <gi...@git.apache.org> on 2016/04/30 05:31:56 UTC
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
GitHub user cowtowncoder opened a pull request:
https://github.com/apache/flink/pull/1952
Jackson version upgrade: default from 2.4.2 to 2.5.5, ES client to latest 2.7
Fix for [FLINK-3855] -- upgrade default Jackson version from 2.4.2 to 2.5.5 (last 2.5 patch); remove unnecessary explicit version ref, and upgrade ES client to latest patch for minor version it refers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cowtowncoder/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1952.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1952
----
commit 243f49a95c971c3caac831ef9131d73d4d562587
Author: Tatu Saloranta <ta...@iki.fi>
Date: 2016-04-30T03:26:27Z
Jackson version upgrade: default from 2.4.2 to 2.5.5 (last patch of next minor version); elastic client to latest patch
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216188894
Yes, I hope so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216466422
The build now fails consistently for the wikipedia connector? Could you push another dummy commit to rerun travis tests. Let's see if it goes away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216487812
There IRC Wikimedia channel is timing out and hence the reason for Wiki test failures, nothing to do with this PR.
LGTM IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-217804461
I'm running a last local test and then merging this. Thanks for the work! \U0001f603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-218967944
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216409045
ElasticSearch 2.x requires jackson >= 2.6.2, hence the Elastic 2.x connector jackson version is set at 2.7.x. Locally, I changed the Jackson version to be 2.7.x in the parent pom and didn't see any issues or tests failures. I think its safe to change the jackson.version to 2.7.4 in parent pom. If so, please remove the <jackson.version> in ElasticSearch2/pom.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216223474
@cowtowncoder do you see a reason for not upgrading all the way to 2.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by cowtowncoder <gi...@git.apache.org>.
Github user cowtowncoder commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216337481
@aljoscha @fhueske Nothing special, just thought I'd start with smallest step, given that this is my first contribution here.
But given that 2.7.4 is out now, I agree that going right there does make most sense and should be safe.
It also looks like most usage is via Tree API (JsonNodes), some streaming; most changes are typically in databinding and very few compatibility issues occur outside databinding. So to me upgrade seems safe either way. And since Elastic-client already uses 2.7 that would allow unification of versions as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1952#discussion_r61670156
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml ---
@@ -55,11 +55,11 @@ under the License.
<version>${elasticsearch.version}</version>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <version>2.7.2</version>
- </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-core</artifactId>
+ <version>2.7.4</version>
--- End diff --
Replace with ${jackson.version} if the parent pom value for this is being changed to 2.7.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by cowtowncoder <gi...@git.apache.org>.
Github user cowtowncoder commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216415361
@smarthi Updated as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1952
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Jackson version upgrade: default from 2.4.2 to...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216167122
@fhueske jackson-databind is only used in the Table API to render the explain output. We should be good to update to latest there as well, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---