You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Cheolsoo Park <ch...@cloudera.com> on 2012/08/13 00:21:45 UTC
Review Request: SQOOP-571 Revert SQOOP-519 and SQOOP-524
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6559/
-----------------------------------------------------------
Review request for Sqoop, Jarek Cecho and Abhijeet Gaikwad.
Description
-------
Please see:
https://issues.apache.org/jira/browse/SQOOP-571
This addresses bug SQOOP-571.
https://issues.apache.org/jira/browse/SQOOP-571
Diffs
-----
/trunk/bin/configure-sqoop 1372202
/trunk/ivy.xml 1372202
/trunk/ivy/libraries.properties 1372202
/trunk/ivy/sqoop-test.xml 1372202
/trunk/ivy/sqoop.xml 1372202
/trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1372202
/trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1372202
/trunk/src/test/com/cloudera/sqoop/TestAvroExport.java 1372202
/trunk/src/test/com/cloudera/sqoop/TestAvroImport.java 1372202
/trunk/src/test/com/cloudera/sqoop/TestExport.java 1372202
/trunk/src/test/com/cloudera/sqoop/TestMultiCols.java 1372202
/trunk/src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1372202
/trunk/src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1372202
/trunk/src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1372202
/trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1372202
/trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1372202
/trunk/src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1372202
/trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1372202
/trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1372202
Diff: https://reviews.apache.org/r/6559/diff/
Testing
-------
ant test
ant checkstyle
ant test -Dthirdparty=true
Thanks,
Cheolsoo Park
Re: Review Request: SQOOP-571 Revert SQOOP-519 and SQOOP-524
Posted by Abhijeet Gaikwad <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6559/#review10260
-----------------------------------------------------------
Ship it!
ant test(20,23,100,200) successful.
- Abhijeet Gaikwad
On Aug. 12, 2012, 10:21 p.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6559/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2012, 10:21 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho and Abhijeet Gaikwad.
>
>
> Description
> -------
>
> Please see:
> https://issues.apache.org/jira/browse/SQOOP-571
>
>
> This addresses bug SQOOP-571.
> https://issues.apache.org/jira/browse/SQOOP-571
>
>
> Diffs
> -----
>
> /trunk/bin/configure-sqoop 1372202
> /trunk/ivy.xml 1372202
> /trunk/ivy/libraries.properties 1372202
> /trunk/ivy/sqoop-test.xml 1372202
> /trunk/ivy/sqoop.xml 1372202
> /trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1372202
> /trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1372202
> /trunk/src/test/com/cloudera/sqoop/TestAvroExport.java 1372202
> /trunk/src/test/com/cloudera/sqoop/TestAvroImport.java 1372202
> /trunk/src/test/com/cloudera/sqoop/TestExport.java 1372202
> /trunk/src/test/com/cloudera/sqoop/TestMultiCols.java 1372202
> /trunk/src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1372202
> /trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1372202
>
> Diff: https://reviews.apache.org/r/6559/diff/
>
>
> Testing
> -------
>
> ant test
> ant checkstyle
> ant test -Dthirdparty=true
>
>
> Thanks,
>
> Cheolsoo Park
>
>
Re: Review Request: SQOOP-571 Revert SQOOP-519 and SQOOP-524
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6559/#review10263
-----------------------------------------------------------
Ship it!
Looks good to me.
- Jarek Cecho
On Aug. 12, 2012, 10:21 p.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6559/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2012, 10:21 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho and Abhijeet Gaikwad.
>
>
> Description
> -------
>
> Please see:
> https://issues.apache.org/jira/browse/SQOOP-571
>
>
> This addresses bug SQOOP-571.
> https://issues.apache.org/jira/browse/SQOOP-571
>
>
> Diffs
> -----
>
> /trunk/bin/configure-sqoop 1372202
> /trunk/ivy.xml 1372202
> /trunk/ivy/libraries.properties 1372202
> /trunk/ivy/sqoop-test.xml 1372202
> /trunk/ivy/sqoop.xml 1372202
> /trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1372202
> /trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1372202
> /trunk/src/test/com/cloudera/sqoop/TestAvroExport.java 1372202
> /trunk/src/test/com/cloudera/sqoop/TestAvroImport.java 1372202
> /trunk/src/test/com/cloudera/sqoop/TestExport.java 1372202
> /trunk/src/test/com/cloudera/sqoop/TestMultiCols.java 1372202
> /trunk/src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1372202
> /trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1372202
> /trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1372202
>
> Diff: https://reviews.apache.org/r/6559/diff/
>
>
> Testing
> -------
>
> ant test
> ant checkstyle
> ant test -Dthirdparty=true
>
>
> Thanks,
>
> Cheolsoo Park
>
>