You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/26 10:45:00 UTC
[jira] [Commented] (FLINK-7526) TaskExecutor should filter out duplicate JobManager gained leadership messages

    [ https://issues.apache.org/jira/browse/FLINK-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142750#comment-16142750 ] 

ASF GitHub Bot commented on FLINK-7526:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4595

    [FLINK-7526] [TaskExecutor] Filter out duplicate JobManager gained leadership messages

    ## What is the purpose of the change
    
    This commit filters out duplicate JobManager gained leadership messges coming from
    the JobLeaderService. This avoid opening multiple connections to the JobManager
    which consumes resources. Moreover, this commit properly closes all
    JobManagerConnections in case of a shut down.
    
    ## Verifying this change
    
    *(Please pick either of the following options)*
    
    This change is already covered by existing tests, such as `TaskExecutorTest#testFilterOutDuplicateJobMasterRegistrations`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixJobMasterRegistration

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4595
    
----
commit 18f62f9dd013e5b0998273110cc764a379097137
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-26T10:40:22Z

    [FLINK-7526] [TaskExecutor] Filter out duplicate JobManager gained leadership messages
    
    This commit filters out duplicate JobManager gained leadership messges coming from
    the JobLeaderService. This avoid opening multiple connections to the JobManager
    which consumes resources. Moreover, this commit properly closes all
    JobManagerConnections in case of a shut down.

----


> TaskExecutor should filter out duplicate JobManager gained leadership messages
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-7526
>                 URL: https://issues.apache.org/jira/browse/FLINK-7526
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> Currently, the {{TaskExecutor}} does not filter out duplicate JobManager gained leadership messages. This causes that multiple {{JobManagerConnections}} are opened which are not properly closed. In order to solve the problem, we should filter out duplicate messages wrt the leader session id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)