You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Andras Salamon <an...@melda.info> on 2018/11/08 09:23:51 UTC
Review Request 69298: OOZIE-3380
TestCoordMaterializeTransitionXCommand failure after DST change date
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69298/
-----------------------------------------------------------
Review request for oozie, András Piros and Kinga Marton.
Repository: oozie-git
Description
-------
OOZIE-3380 TestCoordMaterializeTransitionXCommand failure after DST change date
Diffs
-----
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 49b8732ad
Diff: https://reviews.apache.org/r/69298/diff/1/
Testing
-------
Execued unit tests during the 3 day period after the DST change and also after more than three days.
Thanks,
Andras Salamon
Re: Review Request 69298: OOZIE-3380
TestCoordMaterializeTransitionXCommand failure after DST change date
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69298/#review210472
-----------------------------------------------------------
Ship it!
Ship It!
- Kinga Marton
On Nov. 12, 2018, 2:03 p.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69298/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2018, 2:03 p.m.)
>
>
> Review request for oozie, András Piros and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3380 TestCoordMaterializeTransitionXCommand failure after DST change date
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 49b8732ad
>
>
> Diff: https://reviews.apache.org/r/69298/diff/2/
>
>
> Testing
> -------
>
> Execued unit tests during the 3 day period after the DST change and also after more than three days.
>
>
> Thanks,
>
> Andras Salamon
>
>
Re: Review Request 69298: OOZIE-3380
TestCoordMaterializeTransitionXCommand failure after DST change date
Posted by Andras Salamon <an...@melda.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69298/
-----------------------------------------------------------
(Updated Nov. 12, 2018, 2:03 p.m.)
Review request for oozie, András Piros and Kinga Marton.
Repository: oozie-git
Description
-------
OOZIE-3380 TestCoordMaterializeTransitionXCommand failure after DST change date
Diffs (updated)
-----
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 49b8732ad
Diff: https://reviews.apache.org/r/69298/diff/2/
Changes: https://reviews.apache.org/r/69298/diff/1-2/
Testing
-------
Execued unit tests during the 3 day period after the DST change and also after more than three days.
Thanks,
Andras Salamon
Re: Review Request 69298: OOZIE-3380
TestCoordMaterializeTransitionXCommand failure after DST change date
Posted by Andras Salamon <an...@melda.info>.
> On Nov. 12, 2018, 1:06 p.m., Kinga Marton wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
> > Lines 774 (patched)
> > <https://reviews.apache.org/r/69298/diff/1/?file=2106444#file2106444line814>
> >
> > This issue will affect only one direction of DST change? (the end of DST)
Yes, it will affect only one direction.
- Andras
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69298/#review210465
-----------------------------------------------------------
On Nov. 8, 2018, 9:23 a.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69298/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2018, 9:23 a.m.)
>
>
> Review request for oozie, András Piros and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3380 TestCoordMaterializeTransitionXCommand failure after DST change date
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 49b8732ad
>
>
> Diff: https://reviews.apache.org/r/69298/diff/1/
>
>
> Testing
> -------
>
> Execued unit tests during the 3 day period after the DST change and also after more than three days.
>
>
> Thanks,
>
> Andras Salamon
>
>
Re: Review Request 69298: OOZIE-3380
TestCoordMaterializeTransitionXCommand failure after DST change date
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69298/#review210465
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
Lines 64-66 (patched)
<https://reviews.apache.org/r/69298/#comment295149>
Can you please add static final modifiers for the constants?
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
Lines 774 (patched)
<https://reviews.apache.org/r/69298/#comment295158>
This issue will affect only one direction of DST change? (the end of DST)
- Kinga Marton
On Nov. 8, 2018, 9:23 a.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69298/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2018, 9:23 a.m.)
>
>
> Review request for oozie, András Piros and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3380 TestCoordMaterializeTransitionXCommand failure after DST change date
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 49b8732ad
>
>
> Diff: https://reviews.apache.org/r/69298/diff/1/
>
>
> Testing
> -------
>
> Execued unit tests during the 3 day period after the DST change and also after more than three days.
>
>
> Thanks,
>
> Andras Salamon
>
>