You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/13 01:26:09 UTC
[GitHub] viirya commented on a change in pull request #23760:
[SPARK-26762][SQL][R] Arrow optimization for conversion from Spark
DataFrame to R DataFrame
viirya commented on a change in pull request #23760: [SPARK-26762][SQL][R] Arrow optimization for conversion from Spark DataFrame to R DataFrame
URL: https://github.com/apache/spark/pull/23760#discussion_r256215722
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1177,11 +1177,65 @@ setMethod("dim",
setMethod("collect",
signature(x = "SparkDataFrame"),
function(x, stringsAsFactors = FALSE) {
+ useArrow <- FALSE
+ arrowEnabled <- sparkR.conf("spark.sql.execution.arrow.enabled")[[1]] == "true"
+ if (arrowEnabled) {
+ useArrow <- tryCatch({
+ requireNamespace1 <- requireNamespace
+ if (!requireNamespace1("arrow", quietly = TRUE)) {
+ stop("'arrow' package should be installed.")
+ }
+ # Currenty Arrow optimization does not support raw for now.
+ # Also, it does not support explicit float type set by users.
+ if (inherits(schema(x), "structType")) {
+ if (any(sapply(schema(x)$fields(),
+ function(x) x$dataType.toString() == "FloatType"))) {
+ stop(paste0("Arrow optimization in the conversion from Spark DataFrame to R ",
+ "DataFrame does not support FloatType yet."))
+ }
+ if (any(sapply(schema(x)$fields(),
+ function(x) x$dataType.toString() == "BinaryType"))) {
+ stop(paste0("Arrow optimization in the conversion from Spark DataFrame to R ",
+ "DataFrame does not support BinaryType yet."))
+ }
+ }
+ TRUE
+ }, error = function(e) {
+ warning(paste0("The conversion from Spark DataFrame to R DataFrame was attempted ",
+ "with Arrow optimization because ",
+ "'spark.sql.execution.arrow.enabled' is set to true; however, ",
+ "failed, attempting non-optimization. Reason: ",
+ e))
+ FALSE
+ })
+ }
+
dtypes <- dtypes(x)
ncol <- length(dtypes)
if (ncol <= 0) {
# empty data.frame with 0 columns and 0 rows
data.frame()
+ } else if (useArrow) {
+ requireNamespace1 <- requireNamespace
+ if (requireNamespace1("arrow", quietly = TRUE)) {
+ read_arrow <- get("read_arrow", envir = asNamespace("arrow"), inherits = FALSE)
+ as_tibble <- get("as_tibble", envir = asNamespace("arrow"))
+
+ portAuth <- callJMethod(x@sdf, "collectAsArrowToR")
+ port <- portAuth[[1]]
+ authSecret <- portAuth[[2]]
+ conn <- socketConnection(port = port, blocking = TRUE, open = "wb", timeout = 1500)
+ output <- tryCatch({
+ doServerAuth(conn, authSecret)
+ arrowTable <- read_arrow(readRaw(conn))
+ as.data.frame(as_tibble(arrowTable), stringsAsFactors = stringsAsFactors)
+ }, finally = {
+ close(conn)
+ })
+ return(output)
+ } else {
+ stop("'arrow' package should be installed.")
Review comment:
When `useArrow` is true, I think `arrow` package is installed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org