You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/16 07:37:01 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7972: ARROW-9742: [Rust] [DataFusion] Improved DataFrame trait (formerly known as the Table trait)

jorgecarleitao commented on a change in pull request #7972:
URL: https://github.com/apache/arrow/pull/7972#discussion_r471078546



##########
File path: rust/datafusion/examples/memory_table_api.rs
##########
@@ -51,15 +51,15 @@ fn main() -> Result<()> {
     // declare a table in memory. In spark API, this corresponds to createDataFrame(...).
     let provider = MemTable::new(schema, vec![vec![batch]])?;
     ctx.register_table("t", Box::new(provider));
-    let t = ctx.table("t")?;
+    let df = ctx.table("t")?;

Review comment:
       Shouldn't we also rename `.table` and `.register_table`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org