You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Jing Chen (JIRA)" <ji...@apache.org> on 2018/01/27 12:19:00 UTC

[jira] [Commented] (RATIS-131) Add checkstyle configuration

    [ https://issues.apache.org/jira/browse/RATIS-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342109#comment-16342109 ] 

Jing Chen commented on RATIS-131:
---------------------------------

Hi [~szetszwo], 

would you mind letting me know your suggestion on which phase the checkstyle happens during the build?

Currently, we have two options:
 # checkstyle at the *validate* phase, which checks the code prior to compiling the code, or
 # checkstyle at the *verify* phase, which would check  the code after test phase.

I have my preference at option 2, how about yours?

> Add checkstyle configuration
> ----------------------------
>
>                 Key: RATIS-131
>                 URL: https://issues.apache.org/jira/browse/RATIS-131
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Jing Chen
>            Priority: Major
>
> This JIRA is to setup our checkstyle coding conventions.  We probably should start with [Sun coding conventions|https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml] or [Google coding conventions|https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)