You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/11/09 02:51:54 UTC
[GitHub] [zookeeper] li4wang opened a new pull request, #1944: ZOOKEEPER-4632: Fix NPE from ConnectionMetricsTest.testRevalidateCount
li4wang opened a new pull request, #1944:
URL: https://github.com/apache/zookeeper/pull/1944
Author: Li Wang <li...@apple.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] li4wang commented on pull request #1944: ZOOKEEPER-4632: Fix NPE from ConnectionMetricsTest.testRevalidateCount
Posted by GitBox <gi...@apache.org>.
li4wang commented on PR #1944:
URL: https://github.com/apache/zookeeper/pull/1944#issuecomment-1308187137
Hi @eolivelli, would you mind taking a quick look the PR and get it merged? The prb is currently broken. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] cnauroth merged pull request #1944: ZOOKEEPER-4632: Fix NPE from ConnectionMetricsTest.testRevalidateCount
Posted by GitBox <gi...@apache.org>.
cnauroth merged PR #1944:
URL: https://github.com/apache/zookeeper/pull/1944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] cnauroth commented on pull request #1944: ZOOKEEPER-4632: Fix NPE from ConnectionMetricsTest.testRevalidateCount
Posted by GitBox <gi...@apache.org>.
cnauroth commented on PR #1944:
URL: https://github.com/apache/zookeeper/pull/1944#issuecomment-1312064330
> Do we need one more approval for this? Can @eolivelli or anyone help reviewing it and get it merged? Thanks.
Hi @li4wang . My binding +1 is sufficient to get this into the codebase. I expect I'll be able to take care of it later today. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] li4wang commented on pull request #1944: ZOOKEEPER-4632: Fix NPE from ConnectionMetricsTest.testRevalidateCount
Posted by GitBox <gi...@apache.org>.
li4wang commented on PR #1944:
URL: https://github.com/apache/zookeeper/pull/1944#issuecomment-1312053253
Do we need one more approval for this? Can @eolivelli or anyone help reviewing it and get it merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] cnauroth commented on pull request #1944: ZOOKEEPER-4632: Fix NPE from ConnectionMetricsTest.testRevalidateCount
Posted by GitBox <gi...@apache.org>.
cnauroth commented on PR #1944:
URL: https://github.com/apache/zookeeper/pull/1944#issuecomment-1312873345
I have merged this to master, branch-3.8 and branch-3.7. @li4wang , thank you for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org