You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/04/16 17:36:36 UTC

[GitHub] [calcite] julianhyde commented on a change in pull request #1166: [CALCITE-3004] RexOver is incorrectly pushed down in ProjectSetOpTran…

julianhyde commented on a change in pull request #1166: [CALCITE-3004] RexOver is incorrectly pushed down in ProjectSetOpTran…
URL: https://github.com/apache/calcite/pull/1166#discussion_r275913893
 
 

 ##########
 File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
 ##########
 @@ -9250,15 +9279,16 @@ LogicalProject(NAME=[$0], ENAME=[$2])
 ]]>
         </Resource>
     </TestCase>
-    <TestCase name="testProjectCorrelateTranspose">
+    <TestCase name="testProjectCorrelateTransposeWithOver">
         <Resource name="sql">
 
 Review comment:
   Ah. Somehow there's a duplicate key in RelOptRulesTest.xml. Maybe it's a merge error, I don't know. Can someone add code to DiffRepository to make it fail when reading a .xml file if there are duplicate keys.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services