You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/10 16:46:25 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

chia7712 commented on a change in pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#discussion_r438267308



##########
File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala
##########
@@ -232,12 +232,12 @@ object ConsumerPerformance extends LazyLogging {
       .describedAs("size")
       .ofType(classOf[java.lang.Integer])
       .defaultsTo(2 * 1024 * 1024)
-    val numThreadsOpt = parser.accepts("threads", "Number of processing threads.")
+    val numThreadsOpt = parser.accepts("threads", "Number of processing threads. It has not been implemented.")

Review comment:
       https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/GetOffsetShell.scala#L55 had similar issue and we can follow its style. i.e ```DEPRECATED AND IGNORED:```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org