You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by pabloem <gi...@git.apache.org> on 2017/03/09 00:41:54 UTC
[GitHub] beam pull request #2206: [BEAM-775] Remove Aggregators from internal DoFn ru...
GitHub user pabloem opened a pull request:
https://github.com/apache/beam/pull/2206
[BEAM-775] Remove Aggregators from internal DoFn runner-specific code
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This PR depends on PR 2184 being merged first.
An important note is that it changes the signature of some DoFnRunner implementations. This should probably be reviewed by a Spark and Apex runner developers as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloem/incubator-beam remove-agg-from-runners-java
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2206
----
commit 0d0a490b6850665172570808f12487d04b82484f
Author: Pablo <pa...@google.com>
Date: 2017-03-07T20:50:38Z
Removing Aggregators from Examples
commit 9e51a92a63346f033c35c2eeb60e0b008f36a023
Author: Pablo <pa...@google.com>
Date: 2017-03-07T21:03:27Z
Removing Aggregators from runner-specific examples and tests.
commit 41296b3c4be2ed2aecdfb45648a68703f40e3a92
Author: Pablo <pa...@google.com>
Date: 2017-03-07T21:06:15Z
Removing Aggregators from PipelineResults and subclasses.
commit e7ae2832086dba1d59d4a720ff54cea1097bd039
Author: Pablo <pa...@google.com>
Date: 2017-03-09T00:39:47Z
Removing Aggregator from DoFn and other runner-specific code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2206: [BEAM-775] Remove Aggregators from internal DoFn ru...
Posted by pabloem <gi...@git.apache.org>.
Github user pabloem closed the pull request at:
https://github.com/apache/beam/pull/2206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2206: [BEAM-775] Remove Aggregators from internal DoFn ru...
Posted by pabloem <gi...@git.apache.org>.
GitHub user pabloem reopened a pull request:
https://github.com/apache/beam/pull/2206
[BEAM-775] Remove Aggregators from internal DoFn runner-specific code
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This PR depends on PR 2184 being merged first.
An important note is that it changes the signature of some DoFnRunner implementations. This should probably be reviewed by a Spark and Apex runner developers as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloem/incubator-beam remove-agg-from-runners-java
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2206
----
commit 0d0a490b6850665172570808f12487d04b82484f
Author: Pablo <pa...@google.com>
Date: 2017-03-07T20:50:38Z
Removing Aggregators from Examples
commit 9e51a92a63346f033c35c2eeb60e0b008f36a023
Author: Pablo <pa...@google.com>
Date: 2017-03-07T21:03:27Z
Removing Aggregators from runner-specific examples and tests.
commit 41296b3c4be2ed2aecdfb45648a68703f40e3a92
Author: Pablo <pa...@google.com>
Date: 2017-03-07T21:06:15Z
Removing Aggregators from PipelineResults and subclasses.
commit e7ae2832086dba1d59d4a720ff54cea1097bd039
Author: Pablo <pa...@google.com>
Date: 2017-03-09T00:39:47Z
Removing Aggregator from DoFn and other runner-specific code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2206: [BEAM-775] Remove Aggregators from internal DoFn ru...
Posted by pabloem <gi...@git.apache.org>.
Github user pabloem closed the pull request at:
https://github.com/apache/beam/pull/2206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---