You are viewing a plain text version of this content. The canonical link for it is here.
Posted to site-cvs@tcl.apache.org by mx...@apache.org on 2012/12/17 00:12:30 UTC
svn commit: r1422710 - in /tcl/rivet/trunk: ChangeLog
rivet/packages/session/session-class.tcl src/apache-2/rivetCore.c
Author: mxmanghi
Date: Sun Dec 16 23:12:29 2012
New Revision: 1422710
URL: http://svn.apache.org/viewvc?rev=1422710&view=rev
Log:
* rivet/packages/session/session-class.tcl: method 'store' had a hardcoded 'parray' of
the data when an error occurred. It also printed a message using 'puts' instead of 'debug'
* src/apache-2/rivetCore.c: command 'headers' returns a meaningful error in case
a subcommand is invalid
Modified:
tcl/rivet/trunk/ChangeLog
tcl/rivet/trunk/rivet/packages/session/session-class.tcl
tcl/rivet/trunk/src/apache-2/rivetCore.c
Modified: tcl/rivet/trunk/ChangeLog
URL: http://svn.apache.org/viewvc/tcl/rivet/trunk/ChangeLog?rev=1422710&r1=1422709&r2=1422710&view=diff
==============================================================================
--- tcl/rivet/trunk/ChangeLog (original)
+++ tcl/rivet/trunk/ChangeLog Sun Dec 16 23:12:29 2012
@@ -1,7 +1,15 @@
+2012-12-16 Massimo Manghi <mx...@apache.org>
+ * rivet/packages/session/session-class.tcl: method 'store' had a hardcoded 'parray' of
+ the data when an error occurred. It also printed a message using 'puts' instead of 'debug'
+
+2012-12-15 Massimo Manghi <mx...@apache.org>
+ * src/apache-2/rivetCore.c: command 'headers' returns a meaningful error in case
+ a subcommand is invalid
+
2012-12-12 Massimo Manghi <mx...@apache.org>
* src/apache-2/mod_rivet.c: Tcl_PkgRequire for packages Rivet and rivetlib
are exchanged so that commands in librivet.so can be imported when
- they are on the export list and a programmer issues a 'package require ::rivet'
+ they are on the export list and a programmer issues a 'package require ::rivet' (fixes bug #54290)
* rivet/init.tcl: this script is now providing package 'Rivet' instead of
'RivetTcl'. init.tcl initializes the Tcl core of Rivet and a package rivet
has to exists for compatibility with version 2.0 where it was provided
Modified: tcl/rivet/trunk/rivet/packages/session/session-class.tcl
URL: http://svn.apache.org/viewvc/tcl/rivet/trunk/rivet/packages/session/session-class.tcl?rev=1422710&r1=1422709&r2=1422710&view=diff
==============================================================================
--- tcl/rivet/trunk/rivet/packages/session/session-class.tcl (original)
+++ tcl/rivet/trunk/rivet/packages/session/session-class.tcl Sun Dec 16 23:12:29 2012
@@ -316,8 +316,8 @@ package require Itcl
set kf [list session_id package_ key_]
if {![$dioObject store a -table $sessionCacheTable -keyfield $kf]} {
- puts "Failed to store $sessionCacheTable '$kf'"
- parray a
+ debug "Failed to store $sessionCacheTable '$kf'"
+ #parray a
error [$dioObject errorinfo]
}
}
Modified: tcl/rivet/trunk/src/apache-2/rivetCore.c
URL: http://svn.apache.org/viewvc/tcl/rivet/trunk/src/apache-2/rivetCore.c?rev=1422710&r1=1422709&r2=1422710&view=diff
==============================================================================
--- tcl/rivet/trunk/src/apache-2/rivetCore.c (original)
+++ tcl/rivet/trunk/src/apache-2/rivetCore.c Sun Dec 16 23:12:29 2012
@@ -351,7 +351,8 @@ TCL_CMD_HEADER( Rivet_Headers )
return TCL_ERROR;
}
TclWeb_SetHeaderType(Tcl_GetString(objv[2]), globals->req);
- } else if (!strcmp("numeric", opt)) /* ### numeric ### */
+ }
+ else if (!strcmp("numeric", opt)) /* ### numeric ### */
{
int st = 200;
@@ -365,7 +366,15 @@ TCL_CMD_HEADER( Rivet_Headers )
} else {
return TCL_ERROR;
}
+
} else {
+
+ Tcl_Obj* result = Tcl_NewStringObj("unrecognized subcommand: ",-1);
+ Tcl_IncrRefCount(result);
+ Tcl_AppendStringsToObj(result,opt,NULL);
+
+ Tcl_SetObjResult(interp, result);
+ Tcl_DecrRefCount(result);
return TCL_ERROR;
}
return TCL_OK;
---------------------------------------------------------------------
To unsubscribe, e-mail: site-cvs-unsubscribe@tcl.apache.org
For additional commands, e-mail: site-cvs-help@tcl.apache.org