You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by lukaszlenart <gi...@git.apache.org> on 2017/03/10 08:55:28 UTC
[GitHub] struts pull request #120: WW-4753: Injectable context
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/120
WW-4753: Injectable context
This PR converts statically created validation contexts into injectable beans. It's intermediate step to convert `LocalizedTextUtil` into a bean.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukaszlenart/struts injectable-context
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit da5da67d8027ad2fd05e579c893a4a8a8acd728e
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T07:39:20Z
Makes factory fully injectable
commit db8ebe710d1aaa815006d070b9dda4930a9d152a
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T07:39:55Z
Uses the new injectable factory to obtain TextProvider
commit 728055dc46b2517791d5860d60a77e6196ddcbaf
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T07:40:24Z
Adjust usage of the factory
commit 89d95b64cd68b0b7d03f60249f6202dbb2e14b28
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:17:03Z
Drops empty line
commit 3be5aa0fdb23a69f7dabf3633ca8dd5d09f923dc
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:17:25Z
Adds missing constructor param
commit d7cf0609059c7ffe1f90cc044c9ea20536e823b2
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:20:39Z
Defines new injectable bean with alias
commit 3dc8480988f38f367f9965bad0ff60656d091fa9
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:20:57Z
Updates test
commit c063704d279b6dc7d349c232f17b3b2aebe19b99
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:21:24Z
Renames class to match its purpose
commit 57106ccda2207edb52e575e16cfd47599e9c7110
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:21:28Z
Renames class to match its purpose
commit 451eb883070100dfc57c7635ddc80c57f82f8169
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:37:19Z
Adds missing anntoation to properly inject dependency
commit f56c59c9829347255f5b161ac97dc51069b61fed
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:37:36Z
Defines TextProviderFactory as a bean
commit 55ea82cd4faaecf1f3ca1fffd4428db2471b952d
Author: Lukasz Lenart <lu...@apache.org>
Date: 2017-03-10T08:40:20Z
Uses container to inject required dependencies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request #120: WW-4753: Injectable context
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #120: WW-4753: Injectable context
Posted by cnenning <gi...@git.apache.org>.
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/120
Besides the failing test this looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #120: WW-4753: Injectable context
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/120
Thanks but that failing test is 50% of work ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #120: WW-4753: Injectable context
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/120
All green, if no objections I will merge this PR at the of the day :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #120: WW-4753: Injectable context
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/120
@cnenning done and wasn't that bad when I thought ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org